Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] Add mercure bridge#39342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
OskarStark merged 1 commit intosymfony:5.xfrommtarld:feature/mercure-notifier
Jan 20, 2021

Conversation

@mtarld
Copy link
Contributor

@mtarldmtarld commentedDec 5, 2020•
edited
Loading

QA
Branch?5.x
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix#36481
LicenseMIT
Doc PRsymfony/symfony-docs#14840

Add a Notifier bridge for Mercure.
In this PR, Mercure is considered as a chatter (I'm still wondering if it's the most appropriate type).

The first approach for the DSN ismercure://jwtToken@host:port/hubPath?topic=/foo/1&secure=false with:

  • topic optional (defaults tonull)
  • secure optional (defaults totrue)

I'm not sure about the current way to deal with http/https. Maybe we can just replace themercure scheme byhttp|https?

The notification representation is followingActivity Streams

#SymfonyHackday

ismail1432 reacted with thumbs up emojiwouterj, chalasr, atailouloute, ismail1432, krowek, ochov1, and rimoi reacted with heart emojiismail1432 and axzx reacted with rocket emoji
Copy link
Member

@jderussejderusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could you please add files

  • phpunit.xml.dist
  • README.md

mtarld reacted with thumbs up emoji
@mtarldmtarldforce-pushed thefeature/mercure-notifier branch 4 times, most recently fromf366f12 tob1cb35dCompareDecember 5, 2020 21:53
@jderussejderusse added this to the5.x milestoneDec 5, 2020
@mtarldmtarldforce-pushed thefeature/mercure-notifier branch fromb1cb35d to7c4465bCompareDecember 5, 2020 22:04
@OskarStark
Copy link
Contributor

friendly ping@dunglas 🙂

Copy link
Member

@dunglasdunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you very much for working on this! I think we can make this transport a bit more generic, but it's almost good!

@mtarldmtarldforce-pushed thefeature/mercure-notifier branch 3 times, most recently fromfaa0539 tof2af0e1CompareDecember 8, 2020 12:39
@mtarld
Copy link
ContributorAuthor

In order to make it work,symfony/mercure-bundle#36 has to be merged.
Indeed, this PR adds amercure.publisher tag on each publisher service so that they can be discovered.

@mtarldmtarldforce-pushed thefeature/mercure-notifier branch fromf2af0e1 to69d6bb3CompareDecember 8, 2020 14:27
Copy link
Member

@chalasrchalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

Copy link
Member

@dunglasdunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

for consistency

@mtarldmtarldforce-pushed thefeature/mercure-notifier branch 2 times, most recently from0ecb759 tof9ed6b8CompareJanuary 8, 2021 19:11
@mtarldmtarldforce-pushed thefeature/mercure-notifier branch 4 times, most recently from9695088 to564a77fCompareJanuary 15, 2021 15:26
@OskarStark
Copy link
Contributor

Thanks Mathias for working on this feature, this is much appreciated.

mtarld and ismail1432 reacted with thumbs up emoji

@OskarStarkOskarStark merged commitc6100bc intosymfony:5.xJan 20, 2021
@mtarldmtarld deleted the feature/mercure-notifier branchJanuary 20, 2021 09:09
OskarStark added a commit to symfony/symfony-docs that referenced this pull requestJan 20, 2021
This PR was merged into the 5.3-dev branch.Discussion----------[Notifier] Add Mercure notifier documentationDocumentation related tosymfony/symfony#39342.Commits-------475a87d [Notifier] Add Mercure notifier documentation
@fabpotfabpot mentioned this pull requestApr 18, 2021
weaverryan added a commit to symfony/ux that referenced this pull requestMay 23, 2022
This PR was merged into the 2.x branch.Discussion----------[Notify] Add Notify bundle| Q             | A| ------------- | ---| Bug fix?      | no| New feature?  | yes| Tickets       || License       | MITIn Symfony 5.3, Notifier was shipped with a Mercure bridge (symfony/symfony#39342)Then, with a simple `$this->notifier->send(new Notification('My message', ['chat/mercure']));` (and a running Mercure server), it'll be easy to create "Server-Sent-Events".Therefore, the Notify bundle idea is to listen to these events using JavaScript event sourcing and convert them as native HTML5 notifications (using the `{{ stream_notifications() }}` Twig function).(The "Notify" name was the first that came to my mind a could/should be challenged)Commits-------e02a362 [Notify] Add Notify library
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@stofstofstof left review comments

@jderussejderussejderusse left review comments

@chalasrchalasrchalasr approved these changes

@dunglasdunglasdunglas approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@derrabusderrabusAwaiting requested review from derrabus

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

[Mercure] [Notifier] Add Mercure integration

9 participants

@mtarld@OskarStark@dunglas@nicolas-grekas@stof@jderusse@derrabus@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp