NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Config] YamlReferenceDumper: No default value required for VariableNode with array example#39336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

Nyholm wants to merge2 commits intosymfony:4.4fromNyholm:variable-dumper

Closed

[Config] YamlReferenceDumper: No default value required for VariableNode with array example#39336

Nyholm wants to merge2 commits intosymfony:4.4fromNyholm:variable-dumper

Conversation

Copy link

Member

Nyholm commentedDec 5, 2020•
edited
Loading

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?
Tickets
License	MIT
Doc PR

This willfix#39328 in a better way.

AVariableNode may have an array as value and also a default value as "null". (Like the workflow component).
When we dump the config, we generate invalid yaml:

    workflows:        enabled:              false        workflows:            # Prototype            name:                # Select which Transition events should be dispatched for this Workflow                events_to_dispatch:   null                    # Examples:                    - workflow.enter                    - workflow.transition

With this PR, we will remove thenull default value from the dumped config.

#SymfonyHackday

[Config] YamlReferenceDumper: No default value required for VariableN…

9104fd4

…ode with array example

carsonbot added Status: Needs Review Config Bug labels

Dec 5, 2020

carsonbot added this to the4.4 milestone

Dec 5, 2020

Nyholm mentioned this pull request

Dec 5, 2020

[Workflow] Don't use VariableNode for ArrayNode#39328

Closed

fabpot approved these changes

Dec 5, 2020

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Dec 5, 2020

cs

e4f7d98

Copy link

Member

fabpot commentedDec 5, 2020

Thank you@Nyholm.

fabpot added a commit that referenced this pull request

Dec 5, 2020

bug#39336[Config] YamlReferenceDumper: No default value required fo…

1f6f693

…r VariableNode with array example (Nyholm)This PR was merged into the 4.4 branch.Discussion----------[Config] YamlReferenceDumper: No default value required for VariableNode with array example| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? || Tickets       || License       | MIT| Doc PR        |This willfix#39328 in a better way.A `VariableNode` may have an array as value and also a default value as "null". (Like the workflow component).When we dump the config, we generate invalid yaml:```    workflows:        enabled:              false        workflows:            # Prototype            name:                # Select which Transition events should be dispatched for this Workflow                events_to_dispatch:   null                    # Examples:                    - workflow.enter                    - workflow.transition```With this PR, we will remove the `null` default value from the dumped config.#SymfonyHackdayCommits-------9104fd4 [Config] YamlReferenceDumper: No default value required for VariableNode with array example

Copy link

MemberAuthor