Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Config][TwigBundle] Fixed syntax error in config#39334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
derrabus merged 1 commit intosymfony:4.4fromNyholm:syntax-error
Dec 8, 2020

Conversation

@Nyholm
Copy link
Member

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets
LicenseMIT
Doc PR

Sorry for such small PR. I found this when I was parsing the yaml after runningbin/console config:dump-reference TwigBundle

#SymfonyHackday

@carsonbotcarsonbot added this to the4.4 milestoneDec 5, 2020
@carsonbotcarsonbot changed the title[twigbundle] Fixed syntax error in config[TwigBundle] [twigbundle] Fixed syntax error in configDec 5, 2020
@fabpot
Copy link
Member

Not sure about this one. IIUC, the change is only for YAML, but we have other formats as well where you should not add the quotes, right?

@Nyholm
Copy link
MemberAuthor

Hm. Yes. I'll try to fix this problem by updating the Yaml dumper instead.

@Nyholm
Copy link
MemberAuthor

I've updated the PR, it fixes the same problem but is only updating the dumper instead of the configuration.

@derrabusderrabus changed the title[TwigBundle] [twigbundle] Fixed syntax error in config[TwigBundle] Fixed syntax error in configDec 5, 2020
@carsonbotcarsonbot changed the title[TwigBundle] Fixed syntax error in config[Config][TwigBundle] Fixed syntax error in configDec 5, 2020
@fabpot
Copy link
Member

@Nyholm Can you have a look at the tests?

@Nyholm
Copy link
MemberAuthor

Sure. PR is rebased and tests are updated

@derrabus
Copy link
Member

Thank you Tobias.

@derrabusderrabus merged commit8f331f2 intosymfony:4.4Dec 8, 2020
@Nyholm
Copy link
MemberAuthor

Wohoo. Thank you. Now there is nothing that blocks us to make Carson bot a little bit smarter =)

symfony-tools/carsonbot#141

@NyholmNyholm deleted the syntax-error branchDecember 8, 2020 14:11
@Nyholm
Copy link
MemberAuthor

(except for a branch sync =) )

sstok reacted with laugh emoji

@fabpotfabpot mentioned this pull requestDec 18, 2020
This was referencedDec 18, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@stofstofstof approved these changes

@derrabusderrabusderrabus approved these changes

@ycerutoycerutoyceruto approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

6 participants

@Nyholm@fabpot@derrabus@stof@yceruto@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp