Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Form] do not apply the Valid constraint on scalar form data#39333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 2 commits intosymfony:4.4fromxabbuh:issue-38039
Dec 5, 2020

Conversation

@xabbuh
Copy link
Member

@xabbuhxabbuh commentedDec 5, 2020
edited
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#38039
LicenseMIT
Doc PR

#SymfonyHackday

@fabpot
Copy link
Member

Thank you@xabbuh.

@fabpotfabpot merged commit21ef411 intosymfony:4.4Dec 5, 2020
@xabbuhxabbuh deleted the issue-38039 branchDecember 5, 2020 16:40
This was referencedDec 18, 2020
stof added a commit that referenced this pull requestMar 11, 2022
…ed forms (stof)This PR was merged into the 4.4 branch.Discussion----------[Form] Fix the usage of the Valid constraints in array-based forms| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | n/a| License       | MIT| Doc PR        | n/aThis is a bug introduced in#39333. When wanting to exclude scalar forms, it also excluded array forms.The code now uses the same `\is_object($data) || \is_array($data)` condition for `Valid` constraint than the condition it uses as part of the `$validateDataGraph` condition.The new tests reflects my own use case: an unmapped collection field, were we want to run the validation on that subtree (which is not traversed for other reasons due to being unmapped, and so we need `Valid`). This was working fine in older versions of Symfony, but the validation was silently skipped in 4.4.18+.Commits-------542c2fb Fix the usage of the Valid constraints in array-based forms
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@ycerutoycerutoAwaiting requested review from ycerutoyceruto is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@xabbuh@fabpot@carsonbot@lchrusciel

[8]ページ先頭

©2009-2025 Movatter.jp