NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.7k

[Messenger] Add options to`FailedMessagesShowCommand`#39330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

fguimier wants to merge7 commits intosymfony:6.2fromfguimier:messenger-enhance-failed-show-cmd

Closed

[Messenger] Add options to`FailedMessagesShowCommand`#39330

fguimier wants to merge7 commits intosymfony:6.2fromfguimier:messenger-enhance-failed-show-cmd

Conversation

Copy link

fguimier commentedDec 5, 2020•
edited
Loading

Q	A
Branch?	5.x
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets
License	MIT
Doc PR	symfony/symfony-docs#14689

The goal to this PR is to improve the FailedMessagesShowCommand usability by adding two options:

Thestats option allows to display the number of messages by the class name and have a summary of all the failed messages.

Theclass-filter option is a filter to only display the messages matching with the given class name.

fguimier requested a review fromsroze as acode owner

December 5, 2020 14:24

carsonbot added Status: Needs Review Feature labels

Dec 5, 2020

Copy link

carsonbot commentedDec 5, 2020

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

fguimier changed the title~~Add options to FailedMessagesShowCommand~~[Messenger] Add options to FailedMessagesShowCommand

Dec 5, 2020

jderusse reviewed

Dec 5, 2020

View reviewed changes

src/Symfony/Component/Messenger/Command/FailedMessagesShowCommand.php OutdatedShow resolvedHide resolved

jderusse added this to the5.x milestone

Dec 6, 2020

fguimier added a commit to fguimier/symfony-docs that referenced this pull request

Dec 10, 2020

Update messenger.rst

de9ef23

Update exemples for the messenger:failed:show commandAdd documentation regarding this PRsymfony/symfony#39330

fguimier mentioned this pull request

Dec 10, 2020

[Messenger] Update documentation of messenger:failed:showsymfony/symfony-docs#14688

Closed

fguimier added a commit to fguimier/symfony-docs that referenced this pull request

Dec 10, 2020

Update messenger.rst

5514e52

Update exemples for the messenger:failed:show commandAdd documentation regarding this PRsymfony/symfony#39330

fguimier mentioned this pull request

Dec 10, 2020

[Messenger] Update documentation of messenger:failed:showsymfony/symfony-docs#14689

Closed

fguimier force-pushed themessenger-enhance-failed-show-cmd branch from70c9347 to6d16145Compare

December 29, 2020 09:46

OskarStark changed the title~~[Messenger] Add options to FailedMessagesShowCommand~~[Messenger] Add options toFailedMessagesShowCommand

Aug 4, 2021

OskarStark requested a review fromjderusse

August 4, 2021 20:34

Copy link

Contributor

OskarStark commentedAug 4, 2021

HI, it looks like your commiter email address is not associated with your Github Account:

jderusse reviewed

Aug 4, 2021

View reviewed changes

Copy link

Member

jderusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I like the idea ❤️

src/Symfony/Component/Messenger/Command/FailedMessagesShowCommand.phpShow resolvedHide resolved

src/Symfony/Component/Messenger/Command/FailedMessagesShowCommand.php OutdatedShow resolvedHide resolved

Florian Guimier added2 commits

August 27, 2021 15:16

Add group and class-filter options to FailedMessagesShowCommand

761ae5d

Update changelog

2a43756

fguimier force-pushed themessenger-enhance-failed-show-cmd branch from6d16145 tofeba4b0Compare

August 27, 2021 13:24

review

c6cdb8f

fguimier force-pushed themessenger-enhance-failed-show-cmd branch fromfeba4b0 toc6cdb8fCompare

August 27, 2021 13:29

fguimier added3 commits

August 27, 2021 15:43

Review + fix post-rebase

fd946b1

Fix build

40d7bcf

Add more output in case of class-filter usage

08676a9

derrabus reviewed

Aug 27, 2021

View reviewed changes

src/Symfony/Component/Messenger/CHANGELOG.md OutdatedShow resolvedHide resolved

Update src/Symfony/Component/Messenger/CHANGELOG.md

a2ffddb

Co-authored-by: Alexander M. Turek <me@derrabus.de>

fabpot requested changes

Sep 21, 2021

View reviewed changes

Copy link

Member

fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You should also revert the permission change on src/Symfony/Component/Messenger/Tests/Command/FailedMessagesShowCommandTest.php (get back to 0644)

src/Symfony/Component/Messenger/Tests/Command/FailedMessagesShowCommandTest.php

		Error Code 123
		Error Class Exception
		Transport async
		Transport async

Copy link

Member

fabpotSep 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The extra spaces should be removed

src/Symfony/Component/Messenger/Tests/Command/FailedMessagesShowCommandTest.php

		Error Code 123
		Error Class Exception
		Transport async
		Transport async

Copy link

Member

fabpotSep 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The extra spaces should be removed

carsonbot added Status: Needs Work and removed Status: Needs Review labels

Sep 21, 2021

carsonbot changed the title~~[Messenger] Add options toFailedMessagesShowCommand~~Add options toFailedMessagesShowCommand

Sep 21, 2021

fabpot modified the milestones:5.4,6.1

Nov 16, 2021

nicolas-grekas added the Messenger label

Dec 29, 2021

carsonbot changed the title~~Add options toFailedMessagesShowCommand~~[Messenger] Add options toFailedMessagesShowCommand

Dec 29, 2021

fabpot modified the milestones:6.1,6.2

May 20, 2022

fabpot mentioned this pull request

Jul 21, 2022

[Messenger] Add options toFailedMessagesShowCommand#47008

Merged

Copy link

Member

fabpot commentedJul 21, 2022

Closing in favor of#47008, where I've made some minor changes to finish it.

fabpot closed this

Jul 21, 2022

fabpot added a commit that referenced this pull request

Jul 21, 2022

feature#47008[Messenger] Add options toFailedMessagesShowCommand…

8876dbc

… (Florian Guimier, fabpot)This PR was merged into the 6.2 branch.Discussion----------[Messenger] Add options to `FailedMessagesShowCommand`| Q             | A| ------------- | ---| Branch?       | 6.2| Bug fix?      | no| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       |Fix#39330 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->| License       | MIT| Doc PR        |symfony/symfony-docs#14689See#39330Commits-------e99d2ca Finish work7f774b4 Add group and class-filter options to FailedMessagesShowCommand

javiereguiluz pushed a commit to javiereguiluz/symfony-docs that referenced this pull request

Aug 3, 2022

Update messenger.rst

9d5ac10

Update exemples for the messenger:failed:show commandAdd documentation regarding this PRsymfony/symfony#39330

Labels

Feature Messenger Status: Needs Work

Movatterモバイル変換

Uh oh!

[Messenger] Add options toFailedMessagesShowCommand#39330

[Messenger] Add options toFailedMessagesShowCommand#39330

Uh oh!

Conversation

fguimier commentedDec 5, 2020• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

carsonbot commentedDec 5, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

OskarStark commentedAug 4, 2021

Uh oh!

jderusse left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fabpot left a comment

Choose a reason for hiding this comment

Uh oh!

fabpotSep 21, 2021

Choose a reason for hiding this comment

Uh oh!

fabpotSep 21, 2021

Choose a reason for hiding this comment

Uh oh!

fabpot commentedJul 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

[Messenger] Add options to`FailedMessagesShowCommand`#39330

[Messenger] Add options to`FailedMessagesShowCommand`#39330

fguimier commentedDec 5, 2020•
edited
Loading