NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[FrameworkBundle] TextDescriptor::formatControllerLink checked method…#39313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:4.4fromfjogeleit:fix-text-descriptor-format-controller-link

Dec 5, 2020

Merged

[FrameworkBundle] TextDescriptor::formatControllerLink checked method…#39313

fabpot merged 1 commit intosymfony:4.4fromfjogeleit:fix-text-descriptor-format-controller-link

Dec 5, 2020

Conversation

Copy link

fjogeleit commentedDec 4, 2020

…_exists method before it ensures that $controller is not null

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	-
License	MIT
Doc PR	-

Today I tried PHP8 with Symfony 5.2. - by checking my routes with

bin/console debug:router

It throws

 method_exists(): Argument #1 ($object_or_class) must be of type object|string, null given

The reason is the configured auth route for the login API defined in routes.yaml:

authorization::login:  path: '/login'

This route has no controller configured and the value of $controller inTextDescriptor::formatControllerLink in the FrameworkBundle isnull. This method has a elseif condition withmethod_exists without a check if $controller is a string or object.
In PHP8 this throws an exception/error and did not work. This PR checks that$controller is not null before the method_exists check to prevent this failure.

I'm not sure how to test this in the existing Testsuite

carsonbot added Status: Needs Review FrameworkBundle Bug labels

Dec 4, 2020

carsonbot added this to the4.4 milestone

Dec 4, 2020

Copy link

carsonbot commentedDec 4, 2020

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot