Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpClient] throw clearer error when no scheme is provided#39286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@BackEndTea
Copy link
Contributor

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#39285
LicenseMIT
Doc PRN/A

This could be considred a BC break, as previously this would've aTransportExcepiton, instead of anInvalidArgumentException. But i see no reason to catch this specific error, as it would generally be a configuration error.

@carsonbotcarsonbot added this to the4.4 milestoneDec 2, 2020
@BackEndTeaBackEndTea changed the titleBugfix/http client/no schemeBugfix: throw clearer error when no scheme is providedDec 2, 2020
@carsonbotcarsonbot changed the titleBugfix: throw clearer error when no scheme is provided[HttpClient] Bugfix: throw clearer error when no scheme is providedDec 2, 2020
@derrabusderrabus added the DXDX = Developer eXperience (anything that improves the experience of using Symfony) labelDec 2, 2020
@derrabus
Copy link
Member

Looks reasonable to me. Let's see what@nicolas-grekas thinks about this.

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Works for me, here are some comments.

@nicolas-grekasnicolas-grekas changed the title[HttpClient] Bugfix: throw clearer error when no scheme is provided[HttpClient] throw clearer error when no scheme is providedDec 2, 2020
@fabpot
Copy link
Member

Thank you@BackEndTea.

@fabpotfabpotforce-pushed thebugfix/http-client/no-scheme branch from47c7c63 to4d821d6CompareDecember 5, 2020 06:03
@fabpotfabpot merged commit1177baa intosymfony:4.4Dec 5, 2020
@BackEndTea
Copy link
ContributorAuthor

Thank you@derrabus ,@nicolas-grekas &@fabpot

@BackEndTeaBackEndTea deleted the bugfix/http-client/no-scheme branchDecember 6, 2020 14:16
This was referencedDec 18, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@fabpotfabpotfabpot approved these changes

@jderussejderussejderusse approved these changes

@derrabusderrabusderrabus approved these changes

Assignees

No one assigned

Labels

BugDXDX = Developer eXperience (anything that improves the experience of using Symfony)HttpClientStatus: Reviewed

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

6 participants

@BackEndTea@derrabus@fabpot@nicolas-grekas@jderusse@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp