Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Security] fix #39249, default entry_point compiler pass was returning too early#39261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
chalasr merged 1 commit intosymfony:5.2fromromaricdrigon:fix-39249
Dec 1, 2020

Conversation

@romaricdrigon
Copy link
Contributor

@romaricdrigonromaricdrigon commentedDec 1, 2020•
edited
Loading

QA
Branch?5.2 (bug introduced in 5.2.0, after RC2)
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#39249
LicenseMIT
Doc PRN/A

Areturn instead ofcontinue was making compiler pass return after the first firewall. Hence subsequents firewalls never had a default entrypoint set.
This issue would occur with all firewalls, with any type of authenticator, though I saw it first withhttp_basic - because it is a bit more opaque and harder to debug.

Copy link
Member

@wouterjwouterj left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for report & debugging this issue! And sorry for introducing it 😔

romaricdrigon reacted with heart emoji
@romaricdrigon
Copy link
ContributorAuthor

You are welcome, with as many contributions you do that's fair :)

There's another issue in 5.2.0 security, I'm working an issue and a patch on it, to come in a few minutes too.

@chalasr
Copy link
Member

Good catch, thanks@romaricdrigon.

@chalasrchalasr merged commit0b48115 intosymfony:5.2Dec 1, 2020
@romaricdrigonromaricdrigon deleted the fix-39249 branchDecember 1, 2020 09:46
@fabpotfabpot mentioned this pull requestDec 18, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@wouterjwouterjwouterj approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Security][5.2.0 only bug] Default entry_point selection does not work for 2nd firewall

4 participants

@romaricdrigon@chalasr@wouterj@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp