Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpClient] Fix content swallowed by AsyncClient initializer#39228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.2fromjderusse:fix-retry-content
Dec 10, 2020

Conversation

@jderusse
Copy link
Member

QA
Branch?5.2
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

I'm not sure if it should be fixed in RetryableHttpClient or AsycClient.
The issue is: when the Strategy needs the body to take a decision BUT decide to NOT retry the request, the content is "lost"

In fact, when the first chunk is yield, the AsyncResponse's initializer is stopped, and nothing consume the remaining chunks. Moreover, because thepassthru were disabled before yielding the first chunk in RetryableHttpClient, the callback is never called again to yield the remaining content.

Copy link
Member

@NyholmNyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you@jderusse for your work on this.

@nicolas-grekas
Copy link
Member

As discussed on Slack, this should be fixed inAsyncResponse instead.

@jderussejderusseforce-pushed thefix-retry-content branch 2 times, most recently from785fbe8 tobfc4b10CompareNovember 30, 2020 13:24
Copy link
Member

@NyholmNyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I've tested this and I can confirm that it fixes the issue

@jderussejderusseforce-pushed thefix-retry-content branch 2 times, most recently from1df90ba tob454235CompareDecember 10, 2020 12:11
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM aftersome changes.

@nicolas-grekas
Copy link
Member

Thank you@jderusse.

@nicolas-grekasnicolas-grekas merged commit359bcc5 intosymfony:5.2Dec 10, 2020
@jderussejderusse deleted the fix-retry-content branchDecember 10, 2020 14:16
@fabpotfabpot mentioned this pull requestDec 18, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@NyholmNyholmNyholm approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

4 participants

@jderusse@nicolas-grekas@Nyholm@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp