Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Security] [DX] Automatically add PasswordUpgradeBadge + default support() impl in AbstractFormLoginAuthenticator#39213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
jrushlow approved these changesNov 28, 2020
derrabus requested changesNov 28, 2020
Member
derrabus left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you have a look at the fabbot failures?
afb08dd tob6f52f7CompareMemberAuthor
wouterj commentedNov 28, 2020
Done! Sorry, I forgot to check the PR status after creating it. |
derrabus approved these changesNov 28, 2020
src/Symfony/Component/Security/Http/Authenticator/AbstractLoginFormAuthenticator.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
noniagriconomie approved these changesNov 29, 2020
maxhelias approved these changesNov 29, 2020
fabpot approved these changesNov 30, 2020
…ort() impl in AbstractFormLoginAuthenticator
Member
fabpot commentedNov 30, 2020
Thank you@wouterj. |
a50bdbc to27450c0Compare This was referencedNov 30, 2020
Closed
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
DXDX = Developer eXperience (anything that improves the experience of using Symfony) FeatureSecurityStatus: Reviewed
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
These are 2 suggestions we found while implementing
make:authfor the new system (symfony/maker-bundle#736):Impact on a custom login form authenticator (as generated by the new maker):
PasswordUpgradeBadgeif there is a user password with valid password credentials.// ... return new Passport( new UserBadge($userIdentifier), new PasswordCredentials($password), [- new PasswordUpgradeBadge($password), new CsrfTokenBadge('authenticate', $csrf), ] )PasswordUpgraderInterfaceto be implemented on the user loader/provider.AbstractFormLoginAuthenticator::support()cc@weaverryan@jrushlow