Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Security] [DX] Automatically add PasswordUpgradeBadge + default support() impl in AbstractFormLoginAuthenticator#39213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.2fromwouterj:security/maker-dx-improvements
Nov 30, 2020

Conversation

@wouterj
Copy link
Member

@wouterjwouterj commentedNov 28, 2020
edited
Loading

QA
Branch?5.2 (hopefully? sorry to keep pushing the barrier here)
Bug fix?no
New feature?yes (sort of)
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

These are 2 suggestions we found while implementingmake:auth for the new system (symfony/maker-bundle#736):

Impact on a custom login form authenticator (as generated by the new maker):

  • Automatically addPasswordUpgradeBadge if there is a user password with valid password credentials.
     // ... return new Passport(     new UserBadge($userIdentifier),     new PasswordCredentials($password),     [-        new PasswordUpgradeBadge($password),         new CsrfTokenBadge('authenticate', $csrf),     ] )
    Note that this does not automatically migrate all passwords: it still relies onPasswordUpgraderInterface to be implemented on the user loader/provider.
  • Add default implementation ofAbstractFormLoginAuthenticator::support()
    - public function supports(Request $request): ?bool-  {-      return self::LOGIN_ROUTE === $request->attributes->get('_route')-          && $request->isMethod('POST');- }

cc@weaverryan@jrushlow

@carsonbotcarsonbot added Status: Needs Review Security DXDX = Developer eXperience (anything that improves the experience of using Symfony) Feature labelsNov 28, 2020
@carsonbotcarsonbot changed the title[Security][DX] Automatically add PasswordUpgradeBadge + default support() impl in AbstractFormLoginAuthenticator[Security] [DX] Automatically add PasswordUpgradeBadge + default support() impl in AbstractFormLoginAuthenticatorNov 28, 2020
@wouterjwouterj changed the base branch from5.x to5.2November 28, 2020 16:30
Copy link
Member

@derrabusderrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you have a look at the fabbot failures?

@wouterj
Copy link
MemberAuthor

Done! Sorry, I forgot to check the PR status after creating it.

@derrabusderrabus added this to the5.2 milestoneNov 29, 2020
@fabpot
Copy link
Member

Thank you@wouterj.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@derrabusderrabusderrabus approved these changes

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

+3 more reviewers

@maxheliasmaxheliasmaxhelias approved these changes

@noniagriconomienoniagriconomienoniagriconomie approved these changes

@jrushlowjrushlowjrushlow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

DXDX = Developer eXperience (anything that improves the experience of using Symfony)FeatureSecurityStatus: Reviewed

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

7 participants

@wouterj@fabpot@derrabus@maxhelias@noniagriconomie@jrushlow@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp