Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Serializer] Fix denormalizing scalar with UnwrappingDenormalizer#39180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:5.1fromcamilledejoye:bugfix-38983/scalar-denormalization-unwrappingNov 27, 2020
Merged
[Serializer] Fix denormalizing scalar with UnwrappingDenormalizer#39180
fabpot merged 1 commit intosymfony:5.1fromcamilledejoye:bugfix-38983/scalar-denormalization-unwrappingNov 27, 2020
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
8679530 to21ce093CompareUh oh!
There was an error while loading.Please reload this page.
21ce093 to98cf389Comparederrabus approved these changesNov 26, 2020
fabpot approved these changesNov 27, 2020
Member
fabpot commentedNov 27, 2020
Thank you@camilledejoye. |
hultberg pushed a commit to hultberg/symfony that referenced this pull requestSep 17, 2021
…ngDenormalizer (camilledejoye)This PR was merged into the 5.1 branch.Discussion----------[Serializer] Fix denormalizing scalar with UnwrappingDenormalizer| Q | A| ------------- | ---| Branch? | 5.1| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |Fixsymfony#38983| License | MIT| Doc PR | noneIn order to work the `UnwrappingDenormlizer` needs to be called first to unwrap the data so that it can be handled by other denormalizers.To not introduce any BC break this PR does not move the logic into it's own class, instead it checks if a denormalizer supports the data and only denormalize scalar values if there is none.Commits-------98cf389 fix denormalizing scalar with UnwrappingDenormalizer
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to work the
UnwrappingDenormlizerneeds to be called first to unwrap the data so that it can be handled by other denormalizers.To not introduce any BC break this PR does not move the logic into it's own class, instead it checks if a denormalizer supports the data and only denormalize scalar values if there is none.