Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DependencyInjection] Fixed incorrect report for private services if required service does not exist#39151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@fu22ybear
Copy link
Contributor

…does not exist

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#29359
LicenseMIT
Doc PRno

looks likeCheckExceptionOnInvalidReferenceBehaviorPass can be moved tobeforeRemovingPasses section without any consequences. this solves the problem and all tests still pass

@carsonbotcarsonbot added this to the4.4 milestoneNov 23, 2020
@carsonbotcarsonbot changed the title[DI] fixed incorrect report for private services if required service …[DependencyInjection] [DI] fixed incorrect report for private services if required service …Nov 23, 2020
@fu22ybearfu22ybearforce-pushed theissue-29359-incorrect-service-id-for-non-existent branch fromf962ddd toc86c6e1CompareNovember 23, 2020 17:57
@jderussejderusse changed the title[DependencyInjection] [DI] fixed incorrect report for private services if required service …[DependencyInjection] Fixed incorrect report for private services if required service does not existNov 23, 2020
@fu22ybearfu22ybearforce-pushed theissue-29359-incorrect-service-id-for-non-existent branch fromc86c6e1 tob07d72cCompareNovember 29, 2020 08:13
@fu22ybearfu22ybearforce-pushed theissue-29359-incorrect-service-id-for-non-existent branch fromb07d72c toe5491abCompareNovember 29, 2020 11:36
@fu22ybearfu22ybearforce-pushed theissue-29359-incorrect-service-id-for-non-existent branch frome5491ab to0acbc9eCompareNovember 29, 2020 11:51
@fu22ybearfu22ybearforce-pushed theissue-29359-incorrect-service-id-for-non-existent branch from0acbc9e to1461688CompareNovember 29, 2020 13:14
@derrabusderrabusforce-pushed theissue-29359-incorrect-service-id-for-non-existent branch from1461688 to39bd05cCompareDecember 3, 2020 01:30
@derrabus
Copy link
Member

Thank you@Islam93.

@derrabusderrabus merged commitfbd67c8 intosymfony:4.4Dec 3, 2020
This was referencedDec 18, 2020
nicolas-grekas added a commit that referenced this pull requestFeb 22, 2024
…ng service locators (nicolas-grekas)This PR was merged into the 5.4 branch.Discussion----------[DependencyInjection] Fix computing error messages involving service locators| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? |no| Issues        | -| License       | MITI just realized that#39151 broke the logic in CheckExceptionOnInvalidReferenceBehaviorPass because it relied on inlining pass doing its job. This makes the pass work with and without inlining.Commits-------ca7afaf [DependencyInjection] Fix computing error messages involving service locators
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jderussejderussejderusse left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@fu22ybear@derrabus@nicolas-grekas@jderusse@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp