Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] Add Amazon SNS bridge#39141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromadrien-chinour:5.x
Jul 25, 2021
Merged

[Notifier] Add Amazon SNS bridge#39141

fabpot merged 1 commit intosymfony:5.4fromadrien-chinour:5.x
Jul 25, 2021

Conversation

@adrien-chinour
Copy link
Contributor

@adrien-chinouradrien-chinour commentedNov 22, 2020•
edited
Loading

QA
Branch?5.x
Bug fix?no
New feature?yes
Deprecations?no
Tickets
LicenseMIT
Doc PRsymfony/symfony-docs#15486
Recipe PRsymfony/recipes#847

Hi,

This PR add a bridge on Notifier component for Amazon SNS.

This bridge useasync-aws/sns and only work on actual dev-master version ofasyc-aws/core.

I'm working on recipe and doc PR.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@jderussejderusse modified the milestones:5.1,5.xDec 4, 2020
@OskarStark
Copy link
Contributor

Please create Doc PR, thanks

adrien-chinour reacted with thumbs up emoji

@OskarStarkOskarStark requested review fromjderusse and removed request forjderusseJuly 2, 2021 08:45
@OskarStarkOskarStark requested a review fromNyholmJuly 2, 2021 08:45
$response =$this->snsClient->publish($options);

$message =newSentMessage($message, (string)$this);
$message->setMessageId($response->getMessageId());
Copy link
Member

@jderussejderusseJul 2, 2021•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I would wrap this in a try/catch block to convertAsyncAws exceptions intoTransportException

OskarStark reacted with thumbs up emoji
@fabpot
Copy link
Member

@adrien-chinour Are you still interested in finishing this implementation?

adrien-chinour reacted with thumbs up emoji

@adrien-chinour
Copy link
ContributorAuthor

@adrien-chinour Are you still interested in finishing this implementation?

Yes, I will work on it.

"require": {
"php":">=7.2.5",
"symfony/http-client":"^4.4|^5.2",
"symfony/notifier":"^5.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
"symfony/notifier":"^5.3",
"symfony/notifier":"^5.4",

@OskarStark
Copy link
Contributor

Please add the bridge to theUnsupportedSchemeExceptionTest. Thanks

adrien-chinour reacted with thumbs up emoji

publicfunctiontoArray():array
{
$options =$this->options;
unset($options['recipient_id']);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Why storing the recipient in theoption property if we don't use it not a standard option?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@jderusse Yes, I change it to a class property and a required parameter on constructor.

Copy link
Member

@NyholmNyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you.

I just had some small comments.

@OskarStark
Copy link
Contributor

Final review@Nyholm ?

@fabpot
Copy link
Member

Thank you@adrien-chinour.

adrien-chinour reacted with thumbs up emoji

@fabpotfabpot merged commitccd3a15 intosymfony:5.4Jul 25, 2021
OskarStark added a commit to symfony/symfony-docs that referenced this pull requestJul 25, 2021
This PR was merged into the 5.4 branch.Discussion---------- [Notifier] Add AmazonSns BridgeAmazonSns Bridge :  [symfony/symfony #39141](symfony/symfony#39141)Commits-------6ab1a8d  [Notifier] Add AmazonSns Bridge
This was referencedNov 5, 2021
@jorge-ruukfy

This comment was marked as off-topic.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@jderussejderussejderusse left review comments

@OskarStarkOskarStarkOskarStark approved these changes

@NyholmNyholmNyholm left review comments

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

8 participants

@adrien-chinour@carsonbot@OskarStark@fabpot@jorge-ruukfy@nicolas-grekas@jderusse@Nyholm
[8]ページ先頭
©2009-2025 Movatter.jp