Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DependencyInjection] Fix circular in DI with lazy + byContruct loop#39129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
eerison commentedNov 21, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@jderusse Why are you putting branch 4.4 as target? it's happen when I'm trying to use symfony 5.2 😕 |
Member
derrabus commentedNov 21, 2020
@eerison We always fix bugs on the lowest branch that they occur on. |
884d9b4 tof3515dbComparenicolas-grekas approved these changesNov 27, 2020
Member
nicolas-grekas commentedNov 27, 2020
Thank you@jderusse. |
f3515db to54af139Compare This was referencedNov 29, 2020
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This fix another issue lazy service.
It partially revert#38980 and#39021
Initially, we trusted lazy services to be lazy and not beeing called while building the services graph
=> bug#38970 when lazy deps is injected in a factory, it may be consumed directly to build the object before the graph is fully built
Fixed by#38980 => lazy service are considered as "normal service"
=> bug#39015 some loop are not resolvable with "normal service", but it shouldn't be an issue when servie proxifyied
Fixed by#39021 => lazy service are considered as "normal service" except when proxyfied
=> bug#39120 some loop are not resolvable with "normal service", but it shouldn't be an issue because the lazy service is injected in the constructor and user
Fixed by this PR => that revert to the initial state. lazy service are trusted.
But now, The IterratorArgument injected in a factory (single exception) is not more considered as lazy