Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Yaml] Fix sequence with following mapping#39064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedNov 12, 2020
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
3d9c634 to8531f82Comparexabbuh commentedNov 15, 2020
Thank you@Matth-- for your PR. The change you propose is perfectly valid. But since the handling of sequences/mappings is totally reworked in#33763 due to other edge cases that were also failing I have added your test case there to make your that your issue will be fixed as well. So I am going to close here. Thank you for understanding. |
Matth-- commentedNov 15, 2020
I noticed there were multiple pr's regarding the same function 🙂. 👍 |
This PR was merged into the 4.4 branch.Discussion----------[Yaml] fix lexing nested sequences/mappings| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |#34805,#37788,#37876,#39011,#39013,#39064| License | MIT| Doc PR |Commits-------4c15f80 fix lexing nested sequences/mappings
When handling a sequence (array) on a root level, the closing bracket is not detected (it it is the first character) and every following mapping will throw a
ParseException: Unexpected characters near "XXX" at line X