Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpClient] Check status code before decoding content in TraceableResponse#38977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@chalasr
Copy link
Member

QA
Branch?5.1
Bug fix?yes
New feature?no
Deprecations?np
Tickets-
LicenseMIT
Doc PR-

UsingtoArray() on the response of a traceable client, the status code is currently checked after json decoding, which leads toJsonException being thrown instead ofClientException.
It should be the opposite, as for non-traceable responses.

devster, alborq, and rey0bs reacted with heart emojialborq and rey0bs reacted with rocket emoji
@chalasrchalasrforce-pushed thecheck-status-before-decode branch fromf84c83b to59dc108CompareNovember 3, 2020 17:45
@chalasrchalasrforce-pushed thecheck-status-before-decode branch 2 times, most recently fromb71b74d to57f289aCompareNovember 3, 2020 19:46
@chalasrchalasr changed the title[HttpClient] Check satus code before decoding in TraceableResponse::toArray()[HttpClient] Check satus code before decoding content in TraceableResponseNov 3, 2020
@chalasrchalasrforce-pushed thecheck-status-before-decode branch from57f289a tob69a995CompareNovember 3, 2020 19:59
@chalasrchalasrforce-pushed thecheck-status-before-decode branch 2 times, most recently from3009516 toc4f2d20CompareNovember 3, 2020 20:17
@nicolas-grekasnicolas-grekas changed the title[HttpClient] Check satus code before decoding content in TraceableResponse[HttpClient] Check status code before decoding content in TraceableResponseNov 3, 2020
@chalasrchalasrforce-pushed thecheck-status-before-decode branch 2 times, most recently from7264c27 to640fa70CompareNovember 3, 2020 20:20
@chalasrchalasrforce-pushed thecheck-status-before-decode branch from640fa70 toe5595daCompareNovember 3, 2020 20:21
@nicolas-grekas
Copy link
Member

Good catch, thanks@chalasr.

@nicolas-grekasnicolas-grekas merged commitff7ffdf intosymfony:5.1Nov 3, 2020
@chalasrchalasr deleted the check-status-before-decode branchNovember 3, 2020 20:24
@fabpotfabpot mentioned this pull requestNov 10, 2020
@fabpotfabpot mentioned this pull requestNov 29, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@stofstofstof left review comments

@jderussejderussejderusse left review comments

Assignees

No one assigned

Projects

None yet

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

5 participants

@chalasr@nicolas-grekas@stof@jderusse@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp