Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Intl] deprecate polyfills in favor of symfony/polyfill-intl-icu#38974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
b3cbbd7 to04c1b4dCompare12c7b00 toa8d54bcCompare9c80039 to1421dcfCompare350de91 to2dad6d7CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| } | ||
| /** | ||
| * @requires extension intl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
why ? the polyfill should be enough as they work in the en locale.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
that's the contracts, we don't want to add the polyfill to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
then maybe change that to a check on the class existence (@requires class NumberFormatter) so that it accepts both the polyfill or the extension ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We already have this@requires in the very next test case.
And we don't care to make this testable with the polyfill - that wouldn't provide anything more AFAIK.
Uh oh!
There was an error while loading.Please reload this page.
2dad6d7 to6ad0169CompareThis PR was squashed before being merged into the 5.3-dev branch.Discussion----------[Intl] Remove documentation about deprecated codeThese classes was deprecated insymfony/symfony#38974. They belong to `symfony/polyfill-intl-icu`.This PR willfix#14532Commits-------9a69cac [Intl] Remove documentation about deprecated code
Followssymfony/polyfill#310
/cc@stof