Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Register AddErrorDetailsStampListener from the Messenger component as event subscriber#38941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…enger component as event subscriber
yceruto left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could you please confirm thatErrorDetailsStamp is serialized/deserialized correctly afterbin/console messenger:failed:show <id> -vvv?
Thanks!
jeroennoten commentedNov 1, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Yes, I tested this by installing the skeleton (dev-5.x), configuring Messenger, adding these lines in the vendor directory and removing the cache directory. After doing that, the errors of failed messages were indeed shown when running |
jderusse commentedNov 3, 2020
Thank you@jeroennoten. |
Uh oh!
There was an error while loading.Please reload this page.
This is a fix for a bug in version 5.2-BETA3.
In#32904, adding the error details to a failed message in the Messenger component was moved to a separate listener. However, this listener is not registered in the FrameworkBundle, resulting in no error details stored at all (when using the Symfony skeleton). This PR adds that missing registration.