Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Add "Usages" to debug:container output#38903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@bertterheide
Copy link

@bertterheidebertterheide commentedOct 30, 2020•
edited
Loading

QA
Branch?6.2
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix#37413
LicenseMIT

This feature adds "Usages" output to the debug:container command which allows a user to see which services require the requested service.

chalasr reacted with thumbs up emoji
@Nyholm
Copy link
Member

Wow, what a great first contribution =)

bertterheide and ayyoub-afwallah reacted with thumbs up emoji

Copy link
Member

@derrabusderrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for your pull request. This is really an interesting feature.

@bertterheide
Copy link
Author

Fixed@derrabus's comments in my own commits. Please check again!

@jderussejderusse added this to the5.x milestoneOct 30, 2020
@bertterheidebertterheide changed the titleAdd "Used by" to debug:container outputAdd "Usages" to debug:container outputNov 2, 2020
@fabpotfabpot modified the milestones:5.4,6.1Oct 30, 2021
@fabpot
Copy link
Member

@bertterheide Now that the 6.1 branch is open, can you retarget it and resolve the conflicts. I would love to be able to merge it for the upcoming 6.1 release. Thank you.

@fabpotfabpot modified the milestones:6.1,6.2May 20, 2022
@94noni
Copy link
Contributor

@bertterheide@fabpot Hi, this PR seems stale but could be nice imho, can I try continuing the work on this?
Can be done in parallel of#46814

@Nyholm
Copy link
Member

Since this has been inactive for a while, I assume it safe for you to continue to work.
Make sure to save the existing commits. Ie dont copy the work as your own.

@bertterheide
Copy link
Author

@94noni@Nyholm ill try resolving the conflicts asap so this feature can be merged.

94noni reacted with hooray emoji

@Nyholm
Copy link
Member

Oh, that is awesome! Thank you <3

@94noni
Copy link
Contributor

fantastic thx!

@bertterheidebertterheideforce-pushed thedebug-container-service-usage branch frome29f17a to576a7f6CompareJuly 15, 2022 21:17
@bertterheide
Copy link
Author

Rebased the code on 6.2, updated the PR!

@carsonbotcarsonbot changed the titleAdd "Usages" to debug:container output[FrameworkBundle] Add "Usages" to debug:container outputJul 15, 2022
@fabpot
Copy link
Member

Thank you@bertterheide.

chalasr, yceruto, and bigfoot90 reacted with hooray emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jderussejderussejderusse left review comments

@fabpotfabpotfabpot approved these changes

@chalasrchalasrchalasr approved these changes

@derrabusderrabusAwaiting requested review from derrabus

+1 more reviewer

@94noni94noni94noni left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

Add an option to debug:container CLI command to see service usage

8 participants

@bertterheide@Nyholm@fabpot@94noni@jderusse@derrabus@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp