Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel] Remove Symfony 3 compatibility code#38894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Nyholm approved these changesOct 30, 2020
Member
Nyholm left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
Thank you
Member
Nyholm commentedOct 30, 2020
Could you please rebase to let the tests be green before merge? |
bea0860 tob9ca866CompareMember
Nyholm commentedOct 30, 2020
Woop woop. Thank you very much! |
Merged
nicolas-grekas added a commit that referenced this pull requestApr 11, 2021
…ctSessionListener::onKernelRequest (StefanoCappellini)This PR was submitted for the 5.x branch but it was merged into the 4.4 branch instead.Discussion----------Simplified condition and removed unused code from AbstractSessionListener::onKernelRequest| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | None| License | MITThis PR simplifies a condition and removes unused code (AFAIK coming from#38894)).Commits-------d344b8d Simplified condition and removed unused code from AbstractSessionListener::onKernelRequest
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes dead code that checks for the presence of the
Request::setSessionFactory()method.That method was added with#25836 in HttpFoundation 4.1. Since HttpKernel requires at least HttpFoundation 4.4, we can assume that the method is always present and thus simplify some code here.
Additionally, I also fix the doc block as described in#38892. 😉