Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DoctrineBridge] Fix data extraction in relation using IndexBy and different column name#38883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
derrabus commentedOct 29, 2020
Can you have look at the fabbot failures, please? |
Author
bwach commentedOct 29, 2020
done, thanks for mentioning it |
Member
jderusse commentedOct 29, 2020
Please have a look to a similar PR#38628 |
Member
xabbuh commentedNov 9, 2020
Member
nicolas-grekas commentedNov 9, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue is that the process of property data extraction fails when we have a situation when a relation has an "indexedBy" property set to a field with a column that isn't the same or doesn't follow the naming strategy, for example:
field: foo
colum: bar_baz
I changed it so first we treat it as a field and then we fall back to treating it as a column name as it is now