NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Cache] Fixed expiry could be int in ChainAdapter due to race conditions#38879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 0 commits intosymfony:4.4fromphamviet:PR-38635

Oct 29, 2020

Merged

[Cache] Fixed expiry could be int in ChainAdapter due to race conditions#38879

nicolas-grekas merged 0 commits intosymfony:4.4fromphamviet:PR-38635

Oct 29, 2020

Conversation

Copy link

Contributor

phamviet commentedOct 29, 2020

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix#38635
License	MIT
Doc PR	no

This bug is hard to re-produce and seems only happen with ArrayAdapter only.

Steps to reproduce:

cache.yaml

simple.cache:        adapters:          - cache.adapter.array          - cache.adapter.redis

if (isset($item->metadata[CacheItem::METADATA_EXPIRY])) {$logger->debug($item->key,$item->metadata);$format =is_int($item->metadata[CacheItem::METADATA_EXPIRY]) ?'U' :'U.u';$item->expiresAt(\DateTime::createFromFormat($format,$item->metadata[CacheItem::METADATA_EXPIRY])); }

Refresh webpage multiple time to make web server busy and logs:

[2020-10-29T17:04:51.119653+07:00] application.DEBUG: item-key {"expiry":1603965892.118222,"ctime":4} [][2020-10-29T17:04:54.322937+07:00] application.DEBUG: item-key {"expiry":1603965895.308393,"ctime":17} [][2020-10-29T17:04:54.745923+07:00] application.DEBUG: item-key {"expiry":1603965895,"ctime":16} []