NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[FrameworkBundle] Fixing TranslationUpdateCommand failure when using "--no-backup"#38867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:5.1fromliarco:5.1

Oct 28, 2020

Merged

[FrameworkBundle] Fixing TranslationUpdateCommand failure when using "--no-backup"#38867

fabpot merged 1 commit intosymfony:5.1fromliarco:5.1

Oct 28, 2020

Conversation

Copy link

Contributor

liarco commentedOct 28, 2020•
edited
Loading

Q	A
Branch?	5.1
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets
License	MIT
Doc PR

5.0.0 removedTranslationWriter::disableBackup() butTranslationUpdateCommand still has--no-backup flag. Using that flag throws an error so I think that removing it without deprecation may be the right choice.

Thrown error:

In TranslationUpdateCommand.php line 287:                                                                              Attempted to call an undefined method named "disableBackup" of class "Symfony\Component\Translation\Writer\TranslationWriter".

Further references to the topic: