Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Security] Move AbstractListener abstract methods to the new FirewallListenerInterface#38751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
4b108ee to170a564Compare170a564 to7de8b4eCompare7de8b4e to5dd70bdComparewouterj commentedOct 26, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hmm, I'm not very sure about these changes. But the listener logic is quite complex, so I might completely miss something. What I see:
So, it should be possible to have a class with just an |
chalasr commentedOct 26, 2020
Actually At the time lazy firewalls were introduced,@nicolas-grekas and I talked about deprecating not extending Meanwhile we are reintroducing an interface which, right now, only covers the priority feature. About adding Does this make sense? |
nicolas-grekas left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
big 👍 on my side
this changeenables lazy firewalls (but is not ad hoc for them) because it enables a better design, with a better split of the steps of a firewall
wouterj left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah sorry, I originally was looking at this PR as "purely simplifying" instead of moving to more consistency.
If I understand correctly, the contract already iscallable|FirewallListenerInterface (it needs to be, for BC reasons IIRC). In that case 👍 and we might indeed want to deprecatecallable in Symfony 5.3 (I don't think it's possible to introduce new deprecations after feature freeze?)
nicolas-grekas commentedOct 27, 2020
Thank you@chalasr. |
…heCat)This PR was merged into the 7.4 branch.Discussion----------[Security] Deprecate callable firewall listeners| Q | A| ------------- | ---| Branch? | 7.4| Bug fix? | no| New feature? | no| Deprecations? | yes| Issues | N/A| License | MITAfter spending some time in the Security component it occurred to me callable firewall listeners are obsolete now that we got the `FirewallListenerInterface`. Their deprecation has already been suggested (like in#34627 (comment) or#38751 (review)), so this PR does it.Commits-------510e506 [Security] Deprecate callable firewall listeners
Uh oh!
There was an error while loading.Please reload this page.
We added a FirewallListenerInterface in 5.2, let's make it complete to allow for cleaner firewall listener implementations.