Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DI] Fix Preloader exception when preloading a class with an unknown parent/interface#38713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.4fromrgeraads:preloader-exception
Oct 27, 2020

Conversation

@rgeraads
Copy link

@rgeraadsrgeraads commentedOct 25, 2020•
edited
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#38693
LicenseMIT

Fixes Preloader exception when preloading a class with an unknown parent/interface.

derrabus reacted with thumbs up emoji
@derrabus
Copy link
Member

Did you check if this problem exists on 4.4 as well? If yes, we need to fix it there.

@rgeraads
Copy link
Author

Copy link
Member

@derrabusderrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The change looks correct to me. Just some remarks on the test setup.

@derrabus
Copy link
Member

@derrabus looks like it!

Can you rebase your changes on 4.4 then? If not, that's okay as well. I can do that while merging.

@derrabusderrabus added this to the4.4 milestoneOct 25, 2020
@derrabus
Copy link
Member

Oh, and thank you very much for your PR, of course. 😃

rgeraads reacted with heart emoji

@rgeraadsrgeraads changed the base branch from5.1 to4.1October 25, 2020 13:04
@rgeraadsrgeraads changed the base branch from4.1 to4.4October 25, 2020 13:05
@rgeraads
Copy link
Author

rgeraads commentedOct 25, 2020•
edited
Loading

Can you rebase your changes on 4.4 then? If not, that's okay as well. I can do that while merging.

I rebased it now. Will you port the fix to 5.1 then?

@derrabus
Copy link
Member

derrabus commentedOct 25, 2020•
edited
Loading

Will you port the fix to 5.1 then?

The branches are merged periodically. Changes merged to the 4.4 branch will also be shipped with the next 5.1 release.

rgeraads reacted with thumbs up emoji

@rgeraadsrgeraads changed the titleFix Preloader exception when having a class with an unknown parent/interfaceFix Preloader exception when preloading a class with an unknown parent/interfaceOct 25, 2020
@nicolas-grekasnicolas-grekas changed the titleFix Preloader exception when preloading a class with an unknown parent/interface[DI] Fix Preloader exception when preloading a class with an unknown parent/interfaceOct 27, 2020
@nicolas-grekas
Copy link
Member

Thank you@rgeraads.

rgeraads reacted with heart emoji

@nicolas-grekasnicolas-grekas merged commit19804e1 intosymfony:4.4Oct 27, 2020
@rgeraadsrgeraads deleted the preloader-exception branchOctober 27, 2020 10:10
This was referencedOct 28, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@derrabusderrabusderrabus approved these changes

@dunglasdunglasAwaiting requested review from dunglas

@lyrixxlyrixxAwaiting requested review from lyrixx

@srozesrozeAwaiting requested review from sroze

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@rgeraads@derrabus@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp