Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[PhpUnitBridge] Support new expect methods in test case polyfill#38680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@alcaeus
Copy link
Contributor

@alcaeusalcaeus commentedOct 22, 2020•
edited
Loading

QA
Branch?5.x
Bug fix?no
New feature?yes
Deprecations?no
LicenseMIT

This PR adds theexpectError,expectWarning,expectNotice,andexpectDeprecation methods to the test case polyfill.

Note that I saw aexpectDeprecation message inExpectDeprecationTrait, but I couldn't quite figure out what it's supposed to do. Please let me know if theexpectDeprecation method needs to be removed from the test polyfill.

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedOct 22, 2020•
edited
Loading

ExpectDeprecationTrait predatesexpectDeprecation() and is providing a more useful behavior than the newly added method in phpunit. I don't think we need to polyfill it, because it's just useless as it is...

@alcaeusalcaeusforce-pushed thephpunit-bridge-polyfill-expect-methods branch 2 times, most recently fromc1cf6b8 tod36157eCompareOctober 22, 2020 12:23
@alcaeusalcaeusforce-pushed thephpunit-bridge-polyfill-expect-methods branch fromd36157e to8a49a26CompareOctober 22, 2020 12:28
@alcaeusalcaeus changed the base branch from5.x to4.4October 22, 2020 12:28
@nicolas-grekas
Copy link
Member

We consider such changes as bugfixes (see#37970 for bg)
Please rebase+retarget your PRs for 4.4

@nicolas-grekasnicolas-grekas modified the milestones:5.2,4.4Oct 22, 2020
@fabpot
Copy link
Member

Thank you@alcaeus.

@fabpotfabpot merged commit9bfd3ee intosymfony:4.4Oct 23, 2020
@alcaeusalcaeus deleted the phpunit-bridge-polyfill-expect-methods branchOctober 23, 2020 05:34
This was referencedOct 28, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@alcaeus@nicolas-grekas@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp