Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[RateLimiter] Be more type safe when fetching from cache#38670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
chalasr merged 1 commit intosymfony:5.xfromNyholm:ratelimiter-cache-safe
Oct 22, 2020

Conversation

@Nyholm
Copy link
Member

QA
Branch?5.x
Bug fix?yes
New feature?no
Deprecations?no
Tickets
LicenseMIT
Doc PR

This is a super minor thing. A$cacheItem can be a hit, but it does not contain aLimiterStateInterface.

Also, PSR-6 specifies that if the$cacheItem is not a hit, it must return null.

@NyholmNyholm changed the title[RateLimiter] Be more type safe when fetching form cache[RateLimiter] Be more type safe when fetching from cacheOct 22, 2020
@chalasrchalasr added this to the5.2 milestoneOct 22, 2020
@chalasr
Copy link
Member

Thank you@Nyholm.

@chalasrchalasr merged commit7539325 intosymfony:5.xOct 22, 2020
@Nyholm
Copy link
MemberAuthor

Thank you for reviews and merge.

@fabpotfabpot mentioned this pull requestOct 28, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

4 participants

@Nyholm@chalasr@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp