Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Serializer] fix decoding float XML attributes starting with 0#38669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4frommarcin-kruk:ticket_38666
Oct 23, 2020

Conversation

@marcin-kruk
Copy link

QA
Branch?3.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#38666
LicenseMIT
Doc PRn/a

This is a naive approach tofix#38666, assuming it is something worth fixing.

I checked different cases and it seems to be fixing all of them, but I bet there will be some other edge cases which still won't be covered properly.

Copy link
Member

@NyholmNyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for this PR. I see you added tests and everything. Well done!

I have some questions that I would like your help answering.

@marcin-kruk
Copy link
Author

It seems that fabbot is asking me to fix something I didn't change - an exception message formatting in a different method.
I updated my branch with upstream and it's up to date, so it's not the reason.
Any ideas why it failed and how to sort it out?

@chalasrchalasr added this to the3.4 milestoneOct 22, 2020
@nicolas-grekasnicolas-grekas changed the title[Serializer] fixed decoding float XML attributes started with 0[Serializer] fixed decoding float XML attributes starting with 0Oct 22, 2020
@nicolas-grekasnicolas-grekas changed the title[Serializer] fixed decoding float XML attributes starting with 0[Serializer] fix decoding float XML attributes starting with 0Oct 22, 2020
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(with one minor comment)

Copy link
Member

@NyholmNyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I am happy to merge after@jderusse is happy

Copy link
Member

@jderussejderusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you

Copy link
Member

@dunglasdunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

good catch!

@fabpot
Copy link
Member

Thank you@marcin-kruk.

@fabpotfabpot merged commit85e8de6 intosymfony:3.4Oct 23, 2020
This was referencedOct 28, 2020
This was referencedOct 28, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@dunglasdunglasdunglas approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@jderussejderussejderusse approved these changes

@NyholmNyholmNyholm approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

8 participants

@marcin-kruk@fabpot@dunglas@nicolas-grekas@jderusse@Nyholm@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp