Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[RateLimiter] Moved classes implementing LimiterInterface to a new namespace#38664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.xfromNyholm:limiter-namespace
Oct 25, 2020

Conversation

Nyholm
Copy link
Member

@NyholmNyholm commentedOct 21, 2020•
edited
Loading

QA
Branch?5.x
Bug fix?no
New feature?no
Deprecations?no?
Tickets
LicenseMIT
Doc PR

Before we release the RateLimit component.
I think it would be a good idea to put the 7 classes that belongs to a specific strategy in their own "Policy" namespace. It is very likely that it will be more strategies in the future and theSymfony\Component\RateLimiter namespace is crowed as it is.

I decided not to put theCompoundLimiter in this namespace as it is not a strategy.

@NyholmNyholmforce-pushed thelimiter-namespace branch 6 times, most recently from6468960 to7fd65bcCompareOctober 24, 2020 08:37
@nicolas-grekas
Copy link
Member

Failure is related, isn't it?

@Nyholm
Copy link
MemberAuthor

Yes, they are. Im working on it

@Nyholm
Copy link
MemberAuthor

The tests looks much happyr now.

It is ready for merge.

Copy link
Member

@wouterjwouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you Tobias! Some final remarks, but I think these can also be fixed while merging.

@fabpot
Copy link
Member

Thank you@Nyholm.

@Nyholm
Copy link
MemberAuthor

Thank you for the reviews and merge!

@NyholmNyholm deleted the limiter-namespace branchOctober 25, 2020 08:39
@fabpotfabpot mentioned this pull requestOct 28, 2020
fabpot added a commit that referenced this pull requestMar 13, 2023
…in XSD (MatTheCat)This PR was merged into the 5.4 branch.Discussion----------[FrameworkBundle] Rename limiter’s `strategy` to `policy` in XSD| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |Fix#49671| License       | MIT| Doc PR        | N/A#38664 renamed `strategy` to `policy` but did not update the XSD.Commits-------c19711c [FrameworkBundle] Rename limiter’s `strategy` to `policy` in XSD
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabpotfabpotfabpot left review comments

@stofstofstof approved these changes

@jderussejderussejderusse left review comments

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

@wouterjwouterjwouterj approved these changes

@chalasrchalasrAwaiting requested review from chalasr

Assignees
No one assigned
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.

9 participants
@Nyholm@nicolas-grekas@fabpot@javiereguiluz@stof@jderusse@wouterj@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp