Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpClient] relax auth bearer format requirements#38647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.4fromxabbuh:issue-38609
Oct 24, 2020

Conversation

@xabbuh
Copy link
Member

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#38609
LicenseMIT
Doc PR

@xabbuhxabbuhforce-pushed theissue-38609 branch 2 times, most recently from8b0b581 to45ea1c5CompareOctober 20, 2020 13:53
@wouterj
Copy link
Member

wouterj commentedOct 20, 2020•
edited
Loading

I just found#30561 (which introduced this regex) :

Better be sure CR/LF/etc cannot be passed inside raw header values, opening potential security risks.

Should we still check for these characters, to make sure they are not inside the bearer?

jderusse reacted with thumbs up emoji

@nicolas-grekas
Copy link
Member

Thank you@xabbuh.

@nicolas-grekasnicolas-grekas merged commit4abbb1d intosymfony:4.4Oct 24, 2020
@xabbuhxabbuh deleted the issue-38609 branchOctober 24, 2020 12:01
This was referencedOct 28, 2020
@nicolas-grekasnicolas-grekas mentioned this pull requestFeb 4, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrchalasr left review comments

+1 more reviewer

@ro0NLro0NLro0NL left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

6 participants

@xabbuh@wouterj@nicolas-grekas@ro0NL@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp