Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[TwigBridge] Update bootstrap_4_layout.html.twig#38625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
Oviglo wants to merge1 commit intosymfony:5.xfromOviglo:patch-1
Closed

[TwigBridge] Update bootstrap_4_layout.html.twig#38625

Oviglo wants to merge1 commit intosymfony:5.xfromOviglo:patch-1

Conversation

@Oviglo
Copy link
Contributor

@OvigloOviglo commentedOct 19, 2020•
edited by nicolas-grekas
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

Add 'form-control-range' for range input type.

Add 'form-control-range' for range input type.
@nicolas-grekasnicolas-grekas changed the titleUpdate bootstrap_4_layout.html.twig[TwigBridge] Update bootstrap_4_layout.html.twigOct 19, 2020
@nicolas-grekasnicolas-grekas added this to the4.4 milestoneOct 19, 2020
@nicolas-grekas
Copy link
Member

(for 4.4)
Can you please have a look at failing tests?

@Oviglo
Copy link
ContributorAuthor

(for 4.4)
Can you please have a look at failing tests?

Yes, the test check if class name contains "form-control" but in Bootstrap doc the range input type need to have "form-control-range" :https://getbootstrap.com/docs/4.5/components/forms/#range-inputs

@nicolas-grekas
Copy link
Member

Yes, the test check if class name contains "form-control" but in Bootstrap doc the range input type need to have "form-control-range"

Sure, can you fix the tests please?

Copy link
Member

@NyholmNyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hey.

Have a look how the current custom forms are implemented. (see the docs:https://symfony.com/doc/current/form/bootstrap4.html#custom-forms)

We should implement this in the same way.

@fabpot
Copy link
Member

@Oviglo Are you still interested in finishing this PR?

@nicolas-grekas
Copy link
Member

Closing as this staled.
@Oviglo please submit when you can!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@NyholmNyholmNyholm requested changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

6 participants

@Oviglo@nicolas-grekas@fabpot@Nyholm@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp