Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[WebProfilerBundle] Hide debug toolbar in print view#38606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4fromjt2k:debug-toolbar-hide-print
Oct 16, 2020

Conversation

@jt2k
Copy link
Contributor

QA
Branch?3.4
Bug fix?yes
New feature?no
Deprecations?no
LicenseMIT

The debug toolbar is intended to be hidden when printed. This was accomplished in 2.8 withthis PR. Since then, additional JavaScript code was added which results indisplay: block being applied directly to the toolbar element. This overrides the print style, which causes the toolbar to show up in the print view. I fixed this by adding!important to the print CSS display rule.

A few notes:

  1. I hesitated to solve this with!important but couldn't come up with another way to make this work with the existing JavaScript code. Also,profiler.css.twig already has some!important styles, so I figured this was acceptable.
  2. I wasn't sure how to write a test for this, but I am open to ideas.

@fabpot
Copy link
Member

Thank you@jt2k.

@fabpotfabpot merged commit4b4abc3 intosymfony:3.4Oct 16, 2020
@jt2k
Copy link
ContributorAuthor

Thanks,@fabpot and@stof. I see this is already merged, but I am curious about your comment,@jderusse. According tothe release page, 3.4 is maintained for bug fixes until November 2020. Are we in a window now where bug fixes targeting 3.4 are discouraged due to the proximity to November 2020?

@jderusse
Copy link
Member

@jt2k yes, you're right. sorry for the confusion

@jt2k
Copy link
ContributorAuthor

@jderusse No problem! That was a good reminder for me that 3.4 is going into security-only maintenance soon!

@jt2kjt2k deleted the debug-toolbar-hide-print branchOctober 16, 2020 17:32
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@stofstofstof approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jt2k@fabpot@jderusse@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp