Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DoctrinBridge] make Uid types stricter#38605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.xfromnicolas-grekas:db-uid
Oct 17, 2020

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?5.2
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

Reviewing#38600 made me realize we don't need to deal with converting strings to db values.
We should only support converting actualAbstractUid instances in the DB.
Also, the binary types shouldnot extendGuidType.

@stof
Copy link
Member

Also, the binary types shouldnot extendGuidType.

IMO, none of them should, as they change the PHP format

@nicolas-grekas
Copy link
MemberAuthor

IMO, none of them should, as they change the PHP format

Alright, updated. I also removedrequiresSQLCommentHint() because I don't think comment-hints are required.

@nicolas-grekasnicolas-grekasforce-pushed thedb-uid branch 2 times, most recently fromc7c4251 to2d9c31dCompareOctober 16, 2020 16:47
@stof
Copy link
Member

I also removedrequiresSQLCommentHint() because I don't think comment-hints are required.

they are required, because the type does not register a mapping type, so schema introspection would not recognize them without the special comment

@nicolas-grekas
Copy link
MemberAuthor

Thanks, reverted this part :)

@fabpot
Copy link
Member

Thank you@nicolas-grekas.

@fabpotfabpot merged commitfdf9a43 intosymfony:5.xOct 17, 2020
@nicolas-grekas
Copy link
MemberAuthor

(Partially reverted in#38986)

fabpot added a commit that referenced this pull requestNov 5, 2020
…lues (nicolas-grekas)This PR was merged into the 5.2-dev branch.Discussion----------[DoctrineBridge] accept converting Uid-as-strings to db-values| Q             | A| ------------- | ---| Branch?       | 5.2| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |Fix#38929| License       | MIT| Doc PR        | -In#38605 I made Uid types stricter by taking inspiration from native Doctrine types. But#38929 (comment) made me realize this doesn't work with ParamConverters. Here is the fix.Commits-------20714d6 [DoctrineBridge] accept converting Uid-as-strings to db-values
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

+1 more reviewer

@mvorisekmvorisekmvorisek left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

5 participants

@nicolas-grekas@stof@fabpot@mvorisek@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp