Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[DoctrineBridge] indexBy does not refer to attributes, but to column names#38604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4fromxabbuh:issue-37982
Oct 17, 2020

Conversation

@xabbuh
Copy link
Member

QA
Branch?3.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#37982
LicenseMIT
Doc PR

@fabpot
Copy link
Member

Thank you@xabbuh.

@fabpotfabpot merged commit9761609 intosymfony:3.4Oct 17, 2020
@xabbuhxabbuh deleted the issue-37982 branchOctober 17, 2020 06:38
nicolas-grekas added a commit that referenced this pull requestNov 9, 2020
…lumns (juanmiguelbesada)This PR was squashed before being merged into the 3.4 branch.Discussion----------[DoctrineBridge]  indexBy could reference to association columns| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       |Fix#37982 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->| License       | MIT| Doc PR        | -<!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/releases): - Always add tests and ensure they pass. - Never break backward compatibility (seehttps://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch 5.x.-->This is my approach to solve#37982. It partials reverts@xabbuh PR#38604This is my first Symfony contribution, so please, tell me if I need to do something more or something is wrong.Also, this bug affects 4.x and 5.x versions. I think merging in this branches is done automatically. If not, please tell me.Thanks youCommits-------f9a0e00 failing test for issue 388614c36145 [DoctrineBridge]  indexBy could reference to association columns
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

+1 more reviewer

@dbrumanndbrumanndbrumann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@xabbuh@fabpot@dbrumann@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp