Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Console] Fix signal management#38602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lyrixx merged 1 commit intosymfony:5.xfromchalasr:non-null-registry
Oct 16, 2020
Merged

Conversation

@chalasr
Copy link
Member

@chalasrchalasr commentedOct 16, 2020•
edited
Loading

QA
Branch?5.2
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

Missed in#38589

@lyrixx
Copy link
Member

lyrixx commentedOct 16, 2020•
edited
Loading

There were other issues

$this->signalRegistry->register($signal,function ($signal,$hasNext)use ($event) {

$this->signalRegistry->register($signal, [$command,'handleSignal']);

And this check is wrong too. I mean the error message does not reflect what is going.

if (!$this->signalsToDispatchEvent) {
thrownewRuntimeException('Unable to subscribe to signal events. Make sure that the `pcntl` extension is installed and that "pcntl_*" functions are not disabled by your php.ini\'s "disable_functions" directive.');

Copy link
Member

@lyrixxlyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍🏼
Thank you Robin for taking time of fixing this :)
I'm gonna change the title of your PR to get a "nice" git history

@lyrixxlyrixx changed the title[Console] Fix Application::getSignalRegistry() retval[Console] Fix signal managementOct 16, 2020
@chalasr
Copy link
MemberAuthor

I'm gonna change the title of your PR to get a "nice" git history

Broader, but not wrong :) Thanks!

@lyrixx
Copy link
Member

You were fast on this one, thanks Robin.

@lyrixxlyrixx merged commit6088728 intosymfony:5.xOct 16, 2020
@fabpotfabpot mentioned this pull requestOct 28, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lyrixxlyrixxlyrixx approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

3 participants

@chalasr@lyrixx@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp