NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[TwigBridge] do not translate null placeholders or titles#38595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:3.4fromxabbuh:issue-37573

Oct 21, 2020

Merged

[TwigBridge] do not translate null placeholders or titles#38595

fabpot merged 1 commit intosymfony:3.4fromxabbuh:issue-37573

Oct 21, 2020

Conversation

Copy link

Member

xabbuh commentedOct 16, 2020

Q	A
Branch?	3.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix#37573
License	MIT
Doc PR

do not translate null placeholders or titles

2ee24a0

xabbuh added this to the3.4 milestone

Oct 16, 2020

carsonbot added Status: Needs Review TwigBridge Bug labels

Oct 16, 2020

xabbuh mentioned this pull request

Oct 16, 2020

[Twig, Form Types] Form text field placeholder can not be null. Why?#37573

Closed

Copy link

Member

Im thinking of the label. Currently, if the label attribute is null, we are trying to create/invent a label looking at the ID. It feels weird that the behavior forplaceholder andtitle is not the same.

But I also agree that we should translate null values, because that will cause an error =)

I am 👍 but I want to hear your thoughts on this ^^

Copy link

MemberAuthor

xabbuh commentedOct 16, 2020

Most of the time we can derive useful labels from the field names if it isn't configured. For placeholders and titles that not really possible. I mainly think that usingnull for both of them does not make much sense but I can also see the use case described in#37573 and I agree with the reasoning made there that we should not fail hard over it.