Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[RateLimiter] Adding SlidingWindow algorithm#38565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.xfromNyholm:sliding-window
Oct 15, 2020

Conversation

@Nyholm
Copy link
Member

QA
Branch?5.x
Bug fix?no
New feature?yes
Deprecations?
Tickets
LicenseMIT
Doc PRShould be added

This is a draft PR to make sure we like the idea. I'll keep working on adding tests.

@wouterj
Copy link
Member

👍 I like this. Thanks!

Copy link
Member

@wouterjwouterj left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Apart from my comments, this looks good to me.

@fabpot would be cool to also have this in 5.2, though it's not 100% needed. Sliding windows generally is better than fixed windows, as they flatten bursts much better.

}
}

private function getAvailableTokens(int $hitCount): int
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This method is public inFixedWindow,

@wouterj is that a bug? It is not part of the interface and never used outside of the class.

@fabpot
Copy link
Member

Thank you@Nyholm.

@Nyholm
Copy link
MemberAuthor

Thank you for merging

@NyholmNyholm deleted the sliding-window branchOctober 15, 2020 07:04
@fabpotfabpot mentioned this pull requestOct 28, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@fabpotfabpotfabpot approved these changes

@wouterjwouterjwouterj approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

6 participants

@Nyholm@wouterj@fabpot@OskarStark@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp