Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle][Serializer] Allow serializer default context configuration#38542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromsoyuka:configure-serializer-context
Oct 27, 2021

Conversation

soyuka
Copy link
Contributor

QA
Branch?5.x
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsn/a
LicenseMIT
Doc PRtodo if we go with it

This allow to configure thecontext for normalizer's on a high level:

serializer:default_context:enable_max_depth:true

This feature was asked inapi-platform/core#1764 (comment) and I thought it could be in symfony instead. The messenger component has the same configuration.
This re-opens#28927 (for discussion). I'm still unsure about the discussion in#28927 (comment) and what solution I should implement. Please let me know if you come to an agreement.

chalasr and IonBazan reacted with thumbs up emojimaxhelias and chapterjason reacted with eyes emoji
@stof
Copy link
Member

@soyuka what is the state of this PR ?

@soyuka
Copy link
ContributorAuthor

soyuka commentedOct 22, 2021•
edited
Loading

@stof I'm wondering as well, I'm really not sure that we've come to an agreement on what needs to be done. If the community knows exactly how we can go on, it'll be my pleasure to continue working on it!

Do we actually want this feature?

@norkunas
Copy link
Contributor

I'd like to use this feature. Currently to always expose extended datime format I override datetime normalizer context in compiler pass.

@dunglas
Copy link
Member

I'm in favor of merging this feature

@lyrixx
Copy link
Member

Me too.@soyuka do you have time to finish it, or do you need help?

dunglas and bigfoot90 reacted with thumbs up emoji

@soyuka
Copy link
ContributorAuthor

No problem I'll finish this. About the code I should usesetBinding then? Won't that be a possible conflict with userland? If someone declares a $defaultContext it'll overwrite ours right?

@lyrixx
Copy link
Member

No problem I'll finish this. About the code I should usesetBinding then? Won't that be a possible conflict with userland? If someone declares a $defaultContext it'll overwrite ours right?

yes 👍🏼

soyuka reacted with thumbs up emoji

@soyukasoyukaforce-pushed theconfigure-serializer-context branch 5 times, most recently from53e430b to919719fCompareOctober 26, 2021 12:05
@soyukasoyukaforce-pushed theconfigure-serializer-context branch from919719f to43d1ca5CompareOctober 26, 2021 12:27
Copy link
Member

@lyrixxlyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 👍🏼

@carsonbotcarsonbot changed the titleAllow serializer default context configuration[FrameworkBundle][Serializer] Allow serializer default context configurationOct 26, 2021
@fabpot
Copy link
Member

Thank you@soyuka.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabpotfabpotfabpot approved these changes

@dunglasdunglasdunglas approved these changes

@lyrixxlyrixxlyrixx approved these changes

@chalasrchalasrchalasr approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

10 participants
@soyuka@stof@norkunas@dunglas@lyrixx@fabpot@chalasr@nicolas-grekas@derrabus@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp