Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpFoundation] Fix Range Requests#38516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4fromBattleRattle:bugfix/range-queries
Oct 14, 2020

Conversation

@BattleRattle
Copy link
Contributor

@BattleRattleBattleRattle commentedOct 11, 2020•
edited
Loading

QA
Branch?3.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets#38295
LicenseMIT
Doc PR

This PR fixes some deviations fromRFC 7233 for handling range requests, mentioned in#38295.

  • overlapping ranges are now satisfiable (e.g. when requested range end is larger than the file size)
  • range units other thanbytes will get ignored
  • range requests for methods other thanGET will be ignored

I did not manage yet to implement the support for multiple ranges, but also don't know, if that's needed here.

halaei reacted with thumbs up emoji
@BattleRattleBattleRattle changed the titleBugfix/range queries[HttpFoundation] Fix Range RequestsOct 11, 2020
@nicolas-grekasnicolas-grekas added this to the3.4 milestoneOct 12, 2020
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Doesn't this apply to branch 3.4 also? If yes, this should be rebased+target 3.4.

I did not manage yet to implement the support for multiple ranges, but also don't know, if that's needed here.

It's not needed IMHO.

@BattleRattleBattleRattle changed the base branch from5.1 to3.4October 12, 2020 20:32
@BattleRattle
Copy link
ContributorAuthor

Doesn't this apply to branch 3.4 also? If yes, this should be rebased+target 3.4.

You're right, I changed it to 3.4. Thanks for the hint

@fabpot
Copy link
Member

Thank you@BattleRattle.

@fabpotfabpot merged commit89dddd1 intosymfony:3.4Oct 14, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@dunglasdunglasAwaiting requested review from dunglas

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@BattleRattle@fabpot@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp