This PR is about#37451. The idea is to make that constraint more flexible and able to process business rules, especially when working with objects. We can think about it as the similar feature in UniqueEntity constraint, when we declare on which attributes we are applying the constraint. But in our case it is more general - we pass a callable with whatever logic we want to apply to collection elements before we apply 'uniqueness check' :)

Looks like no BC breaks. Thanks! :)

carsonbot added Status: Needs Review Validator Feature labels

Oct 8, 2020

nicolas-grekas added this to the5.x milestone

Oct 12, 2020

henry2778 force-pushed thefeature/unique-validator-normalizer-5.x branch frome4ed9f6 to3205952Compare

October 18, 2020 19:39

derrabus requested changes

Feb 21, 2021

View reviewed changes

Copy link

Member

derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm sorry nobody has picked up that PR yet. I think, this change could be a useful addition to the unique validator.

src/Symfony/Component/Validator/Constraints/Unique.php OutdatedShow resolvedHide resolved

src/Symfony/Component/Validator/Constraints/UniqueValidator.php OutdatedShow resolvedHide resolved

src/Symfony/Component/Validator/CHANGELOG.md OutdatedShow resolvedHide resolved

carsonbot added Status: Needs Work and removed Status: Needs Review labels

Feb 21, 2021

henry2778 force-pushed thefeature/unique-validator-normalizer-5.x branch fromdb37354 to00b2a49Compare

March 1, 2021 19:14

henry2778 requested a review fromderrabus

March 1, 2021 19:17

carsonbot added Status: Needs Review and removed Status: Needs Work labels

Mar 1, 2021

derrabus requested changes

Mar 1, 2021

View reviewed changes

Copy link

Member

derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks a lot. We're almost good. 😃

src/Symfony/Component/Validator/Tests/Constraints/UniqueTest.phpShow resolvedHide resolved

src/Symfony/Component/Validator/Tests/Constraints/UniqueValidatorTest.php Outdated

		@@ -16,6 +16,14 @@
		use Symfony\Component\Validator\Exception\UnexpectedValueException;
		use Symfony\Component\Validator\Test\ConstraintValidatorTestCase;

		class CallableClass

Copy link

Member

derrabusMar 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please declare the test case class first. This fixture class should be moved to the end of the file.

src/Symfony/Component/Validator/Tests/Constraints/UniqueValidatorTest.php OutdatedShow resolvedHide resolved

carsonbot added Status: Needs Work and removed Status: Needs Review labels

Mar 1, 2021

henry2778 force-pushed thefeature/unique-validator-normalizer-5.x branch from602ed32 to03b91f7Compare

March 16, 2021 21:02

henry2778 requested a review fromderrabus

March 16, 2021 21:20

carsonbot added Status: Needs Review and removed Status: Needs Work labels

Mar 16, 2021

derrabus approved these changes

Mar 16, 2021

View reviewed changes

src/Symfony/Component/Validator/CHANGELOG.md OutdatedShow resolvedHide resolved

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Mar 16, 2021

derrabus added the Ready label

Mar 16, 2021

fabpot approved these changes

Mar 17, 2021

View reviewed changes

Copy link

Member

fabpot commentedMar 17, 2021

@henry2778 Can you have a look at the failing tests? It seems related to the changes here. Thank you.

Copy link

ContributorAuthor

henry2778 commentedMar 17, 2021

@henry2778 Can you have a look at the failing tests? It seems related to the changes here. Thank you.

thanks! fixed

derrabus changed the title~~[Validator] Add valueNormalizer option to Unique Constraint~~[Validator] Add normalizer option to Unique constraint

Mar 17, 2021

[Validator] Add normalizer option to Unique constraint

44e1e8b

derrabus force-pushed thefeature/unique-validator-normalizer-5.x branch from51c36bf to44e1e8bCompare

March 18, 2021 14:44

Copy link

Member

derrabus commentedMar 18, 2021

Thank you@henry2778.

derrabus merged commit1c22e6a intosymfony:5.x

Mar 18, 2021

derrabus mentioned this pull request

Mar 18, 2021

[Validator] Add normalizer option to Unique constraintsymfony/symfony-docs#15122

Closed

henry2778 mentioned this pull request

Mar 19, 2021

[Validator] Add normalizer option to Unique constraintsymfony/symfony-docs#15124

Merged

javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request

Mar 27, 2021

minor#15124[Validator] Add normalizer option to Unique constraint (…

b4d93f3

…henry2778)This PR was squashed before being merged into the 5.3-dev branch.Discussion----------[Validator] Add normalizer option to Unique constraintHello. Documenting  the featuresymfony/symfony#38488 about `normalizer` option for Unique constraint.1. Updated the intro paragraph mentioning the strict comparison2. Added normalizer to the option list3. Added normalizer option description. There is a include file for that, but since the description is slightly different, I decided not use it.Thanks!Commits-------92072d9 [Validator] Add normalizer option to Unique constraint