Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] Add "choice_translation_parameters" option#38469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@VincentLanglet
Copy link
Contributor

QA
Branch?5.x
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix#36845
LicenseMIT
Doc PRsymfony/symfony-docs#13677

Original PR:#36851

nclavaud reacted with hooray emoji
@nicolas-grekasnicolas-grekas changed the titleChoice translation parameters[Form] Add "choice_translation_parameters" optionOct 12, 2020
@nicolas-grekasnicolas-grekas added this to the5.x milestoneOct 12, 2020
@VincentLanglet
Copy link
ContributorAuthor

As explained here:#36851 (comment)

I don't know how to avoid the deprecation in the tests (that's why they are failing).
That's the last thing before being RTM.

Could you help me@fabpot@xabbuh@nicolas-grekas ? Thanks.

@VincentLanglet
Copy link
ContributorAuthor

@fabpot@xabbuh@nicolas-grekas This PR is ready to merge except the deprecation in the tests.
But I don't know how to get rid of it... Could you give me some help ?

@VincentLangletVincentLangletforce-pushed thechoice_translation_parameters branch from1564411 to4606b5fCompareDecember 6, 2020 22:50
@VincentLanglet
Copy link
ContributorAuthor

I rebased, it should be RTM

Copy link
Member

@ycerutoyceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

@fabpotfabpotforce-pushed thechoice_translation_parameters branch from50dcd1c to1ce5b03CompareDecember 10, 2020 07:13
@fabpot
Copy link
Member

Thank you@VincentLanglet.

@fabpotfabpot merged commit9b64be8 intosymfony:5.xDec 10, 2020
OskarStark added a commit to symfony/symfony-docs that referenced this pull requestJan 21, 2021
…Langlet)This PR was merged into the 5.3-dev branch.Discussion----------[Form] Add choice_translation_parameters optionCherry pick of#13677The feature is mergedsymfony/symfony#38469Commits-------0470b00 Add choice_translation_parameters option
@fabpotfabpot mentioned this pull requestApr 18, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@ycerutoycerutoyceruto approved these changes

@xabbuhxabbuhAwaiting requested review from xabbuh

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

ChoiceType Field should have a choice_translation_parameters option.

5 participants

@VincentLanglet@fabpot@nicolas-grekas@yceruto@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp