Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[PhpUnitBridge] Fix Deprecation file when it comes from the TestsListener#38384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@fancyweb
Copy link
Contributor

QA
Branch?5.1
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

#38031 caused an unwanted regression: if the frameclass matchesSymfonyTestsListenerFor it used to always return, now it continues so theoriginClass andoriginMethod properties are set. Therefore, the deprecation is considered as coming from the test listener. It ends up in the "legacy" group and muted because the test listeners contains the word "Legacy" in their namespaces.

Example test:

<?phpnamespaceApp\Tests;usePHPUnit\Framework\TestCase;useSymfony\Component\EventDispatcher\DependencyInjection\ExtractingEventDispatcher;finalclass FooTestextends TestCase{publicfunctiontest():void    {// ExtractingEventDispatcher is @internalnewclassextends ExtractingEventDispatcher {};$this->assertTrue(true);    }}

On 4.4:

Other deprecation notices (1)  1x: The "Symfony\Component\EventDispatcher\DependencyInjection\ExtractingEventDispatcher" class is considered internal. It may change without further notice. You should not use it from "Symfony\Component\EventDispatcher\DependencyInjection\ExtractingEventDispatcher@anonymous".

On 5.1:

Legacy deprecation notices (1)

@fancywebfancywebforce-pushed thephp-unit-bridge-fix-deprecation-file branch from59226a5 to1ba06a0CompareOctober 2, 2020 12:58
@nicolas-grekas
Copy link
Member

Thank you@fancyweb.

@nicolas-grekasnicolas-grekas merged commit8ae323b intosymfony:5.1Oct 2, 2020
@fancywebfancyweb deleted the php-unit-bridge-fix-deprecation-file branchOctober 2, 2020 12:59
@fabpotfabpot mentioned this pull requestOct 4, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

3 participants

@fancyweb@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp