Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PhpUnitBridge] Fix Deprecation file when it comes from the TestsListener#38384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:5.1fromfancyweb:php-unit-bridge-fix-deprecation-fileOct 2, 2020
Merged
[PhpUnitBridge] Fix Deprecation file when it comes from the TestsListener#38384
nicolas-grekas merged 1 commit intosymfony:5.1fromfancyweb:php-unit-bridge-fix-deprecation-fileOct 2, 2020
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
59226a5 to1ba06a0Comparenicolas-grekas approved these changesOct 2, 2020
Member
nicolas-grekas commentedOct 2, 2020
Thank you@fancyweb. |
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#38031 caused an unwanted regression: if the frame
classmatchesSymfonyTestsListenerForit used to always return, now it continues so theoriginClassandoriginMethodproperties are set. Therefore, the deprecation is considered as coming from the test listener. It ends up in the "legacy" group and muted because the test listeners contains the word "Legacy" in their namespaces.Example test:
On 4.4:
On 5.1: