Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpFoundation] Expired cookies string representation consistency & tests#38369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
stof reviewedOct 1, 2020
Uh oh!
There was an error while loading.Please reload this page.
fabpot approved these changesOct 4, 2020
Member
fabpot commentedOct 4, 2020
Thank you@iquito. |
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
These changes add consistent behavior when converting expired cookies back and forth from string representation into
Symfony\Component\HttpFoundation\Cookieinstances inCookie::fromString:Max-Ageis zero andexpiresis in the past, theexpiresdate is kept as is (previous behavior:expiresis overwritten with current timestamp because it is reset to current timestamp +Max-Age)Max-Ageis zero andexpiresis in the future, expires is reset to current timestamp, asMax-Ageis the preferred "source of truth" (same as previous behavior)Max-Agein a cookie string and howexpiresandMax-AgeinteractexpiresTimestampso converting to a unix timestamp can be reused inCookie::fromStringThis is more a new feature than a bug fix in my mind, therefore I would include it in 5.1+.