Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Yaml] fix parsing comments not prefixed by a space#38229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
xabbuh merged 1 commit intosymfony:3.4fromxabbuh:issue-38223
Sep 18, 2020

Conversation

@xabbuh
Copy link
Member

QA
Branch?3.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#38223
LicenseMIT
Doc PR

@stof
Copy link
Member

how does this behave for unquoted values ?

@xabbuh
Copy link
MemberAuthor

xabbuh commentedSep 18, 2020•
edited
Loading

@stof Works the same as before because the internal pointer already points at the end of the unquoted string when the changed line of code is reached. Though I added an additional test case to ensure this doesn't accidentally break in the future.

@stof
Copy link
Member

@xabbuh great

@xabbuhxabbuh merged commit74f41f3 intosymfony:3.4Sep 18, 2020
@xabbuhxabbuh deleted the issue-38223 branchSeptember 18, 2020 09:30
This was referencedSep 27, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@stofstofstof approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@xabbuh@stof@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp