Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[String] improve slugger's portability accross implementations of iconv()#38195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
kdambekalns commentedSep 15, 2020
I'd love to help, but none of the linked issues are known to me… 🤷♂️ |
nicolas-grekas commentedSep 15, 2020
Oups sorry@kdambekalns , bad ping. @edguar could you please have a look? |
dfec24b to21e4e32CompareSurfoo commentedSep 15, 2020
Hello@nicolas-grekas, Works for me, thank you! Just for my curiosity, why don't you have some unit tests on a matrix of differents environments? |
nicolas-grekas commentedSep 15, 2020
Having a matrix of possible iconv implementations looks impossible to me. That's a zoo I know nothing about... |
fabpot commentedSep 16, 2020
Thank you@nicolas-grekas. |
Uh oh!
There was an error while loading.Please reload this page.
Ping@Surfoo@edguar, can you please confirm that this fixes your issues?