Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Console] work around disabled putenv()#38166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromsentisso:patch-1
Sep 15, 2020
Merged

Conversation

@sentisso
Copy link
Contributor

@sentissosentisso commentedSep 12, 2020•
edited by nicolas-grekas
Loading

If this is set to true, then putenv functions simply won't be run in this script, making this function usable on servers, where putenv is disabled

QA
Branch?4.4
Bug fix?no
New feature?yes
Deprecations?no
LicenseMIT
Doc PRsymfony/symfony-docs#...

@fabpot
Copy link
Member

As nobody had this issue before, I'm wondering if we should really cover this case.

@nicolas-grekasnicolas-grekas added this to the4.4 milestoneSep 14, 2020
@nicolas-grekasnicolas-grekas changed the titleadd dontRunPutenv attribute[Console] add dontRunPutenv attributeSep 14, 2020
@nicolas-grekasnicolas-grekas changed the title[Console] add dontRunPutenv attribute[Console] work around disabled putenv()Sep 15, 2020
@nicolas-grekasnicolas-grekas changed the base branch frommaster to3.4September 15, 2020 07:31
@nicolas-grekasnicolas-grekas modified the milestones:4.4,3.4Sep 15, 2020
@nicolas-grekasnicolas-grekas modified the milestones:3.4,4.4Sep 15, 2020
@nicolas-grekasnicolas-grekas changed the base branch from3.4 to4.4September 15, 2020 07:57
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I rebased the PR on 4.4 and made the changes to make this seamless.
OK on my side from a technical pov.

@lyrixxlyrixx removed their request for reviewSeptember 15, 2020 09:56
@fabpot
Copy link
Member

Thank you@sentisso.

sentisso reacted with hooray emoji

@fabpotfabpot merged commite608d05 intosymfony:4.4Sep 15, 2020
This was referencedSep 27, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@dunglasdunglasAwaiting requested review from dunglas

@srozesrozeAwaiting requested review from sroze

@xabbuhxabbuhAwaiting requested review from xabbuh

+2 more reviewers

@azjezzazjezzazjezz left review comments

@maxheliasmaxheliasmaxhelias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

7 participants

@sentisso@fabpot@nicolas-grekas@maxhelias@azjezz@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp