Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Upgrade PHPUnit to 8.5 (php 7.2) and 9.3 (php >= 7.3)#38103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
MemberAuthor
derrabus commentedSep 7, 2020
Regarding the CI failure: The PhpDoc-Parser of PHPUnit 9.3 breaks when being called on a internal class. I'll look into this. Either we work around this problem in PhpUnitBridge or I submit a fix to PHPUnit. |
Contributor
sanmai commentedSep 8, 2020
#38094 might be related. |
MemberAuthor
derrabus commentedSep 8, 2020
PHPUnit won't ship a fix (seesebastianbergmann/phpunit#4448), so I'm going for the workaround now. |
8ac37db to9af37ecComparefabpot added a commit that referenced this pull requestSep 13, 2020
This PR was submitted for the master branch but it was merged into the 4.4 branch instead.Discussion----------[PhpUnitBridge] Internal classes are not legacy| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |#37564| License | MIT| Doc PR | N/AThis change works around the issue that we can observe in the failed Travis build of#38103.We must not call PHPUnit's internal `Test::getGroups()` method with a built-in class, otherwise we will run into a TypeError. This won't be fixed on PHPUnit's side, so we need to prevent that call. Our DeprecationErrorHander might run into this case if a deprecation is triggered while autoloading a class.And forgive me, I've had a really hard time trying to craft a test case for that. 🙈Commits-------7d55e0c Internal classes are not legacy.
9af37ec toff47516CompareMemberAuthor
derrabus commentedSep 14, 2020
We're green! 🎉 |
fabpot approved these changesSep 14, 2020
Member
fabpot commentedSep 14, 2020
Thank you@derrabus. |
fabpot added a commit that referenced this pull requestSep 17, 2020
…errabus)This PR was merged into the 4.4 branch.Discussion----------Upgrade PHPUnit to 8.5 (php 7.2) and 9.3 (php >= 7.3)| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets |#37564| License | MIT| Doc PR | N/AThis is#38103 on the 4.4 branch.Commits-------73647e5 Upgrade PHPUnit to 8.5 (php 7.2) and 9.3 (php >= 7.3).
fabpot added a commit that referenced this pull requestSep 29, 2020
… Clouet)This PR was squashed before being merged into the 5.2-dev branch.Discussion----------[Validator] Add Ulid constraint and validator| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets |Fix#38152| License | MITULID constraint and validator as mentioned in ticket#38103I checked for it ulid specificationshttps://github.com/ulid/specCommits-------e36fd55 [Validator] Add Ulid constraint and validator
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our test suite on the 3.4 branch should be compatible with more recent versions of PHPUnit now. In order to make sure that it stays that way, I'm proposing to bump PHPUnit to 8.5 for the php 7.2 job and 9.3 for the php 7.3 and 7.4 jobs.