Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[PhpUnitBridge] Skip internal classes in CoverageListenerTrait#38094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 0 commits intosymfony:4.4fromsanmai:patch-1
Sep 8, 2020
Merged

Conversation

@sanmai
Copy link
Contributor

@sanmaisanmai commentedSep 7, 2020•
edited
Loading

PHPUnit 9+ is picky about test covering, say, a\RuntimeException. Fails with the likes:

"@covers RuntimeException" is invalid

Judging by the commitsebastianbergmann/phpunit@e06850c this change is required for PHPUnit 9.1 and up.Here's it being tested.

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFollow-up to#38054
LicenseMIT

@sanmai
Copy link
ContributorAuthor

@derrabus if you have a second to have a look

@derrabus
Copy link
Member

Can you provide an example of a test that would fail without your changes?

@sanmai
Copy link
ContributorAuthor

sanmai commentedSep 7, 2020•
edited
Loading

Sure,this is how it looks.

ThisFileNotFound extendsRuntimeException, so both will be inside$covers array.

@chalasrchalasr added this to the4.4 milestoneSep 7, 2020
@sanmai
Copy link
ContributorAuthor

sanmai commentedSep 7, 2020•
edited
Loading

@nicolas-grekasnicolas-grekas changed the title[PhpUnitBridge] Exclude non-namespaced classes[PhpUnitBridge] Exclude internal classesSep 8, 2020
@nicolas-grekasnicolas-grekas changed the title[PhpUnitBridge] Exclude internal classes[PhpUnitBridge] Skip internal classes in CoverageListenerTraitSep 8, 2020
@nicolas-grekas
Copy link
Member

Thank you@sanmai.

sanmai and derrabus reacted with hooray emoji

@nicolas-grekasnicolas-grekas merged commitba61d89 intosymfony:4.4Sep 8, 2020
@sanmaisanmai deleted the patch-1 branchSeptember 8, 2020 07:26
nicolas-grekas added a commit that referenced this pull requestSep 15, 2020
This PR was merged into the 4.4 branch.Discussion----------[PhpUnitBridge] Fix error with ReflectionClass| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| License       | MITIntroduced in#38094. Wish I know how I missed that.Commits-------ed1bffe [PhpUnitBridge] Fix error with ReflectionClass
This was referencedSep 27, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@sanmai@derrabus@nicolas-grekas@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp