Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[VarDumper] Fix caster for invalid SplFileInfo objects on php 8#38073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@derrabus
Copy link
Member

@derrabusderrabus commentedSep 5, 2020•
edited
Loading

QA
Branch?3.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets#36872
LicenseMIT
Doc PRN/A

The behavior of uninitializedSplFileInfo classes has changed in php 8:https://3v4l.org/s4c4O

  • getPathname() won't returnfalse anymore.
  • The error raised by most accessors is now recoverable. On php 7, it's fatal.

This PR adjusts the caster for those objects to the new behavior.

@derrabusderrabusforce-pushed thebugfix/uninitialized-spl-file-info branch from9c8a25f toab45e2aCompareSeptember 5, 2020 17:45
@fabpot
Copy link
Member

Thank you@derrabus.

@fabpotfabpot merged commitee8fc9c intosymfony:3.4Sep 6, 2020
@derrabusderrabus deleted the bugfix/uninitialized-spl-file-info branchSeptember 6, 2020 15:56
This was referencedSep 27, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@derrabus@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp