Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[PhpUnitBridge] CoverageListenerTrait update for PHPUnit 8.5/9.x#38054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromsanmai:pr/SymfonyTestsListenerTrait
Sep 4, 2020
Merged

[PhpUnitBridge] CoverageListenerTrait update for PHPUnit 8.5/9.x#38054

fabpot merged 1 commit intosymfony:4.4fromsanmai:pr/SymfonyTestsListenerTrait
Sep 4, 2020

Conversation

@sanmai
Copy link
Contributor

@sanmaisanmai commentedSep 4, 2020
edited
Loading

Updated to usePHPUnit\Util\Annotation\Registry and related classes.

Fixes#37637

QA
Branch?4.4
Bug fix?yes
New feature?yes
Deprecations?no
TicketsFix#37637
LicenseMIT
Doc PRn/a
  • Fixes the issue under PHPUnit 8.5+
  • Tests TBD

If this is a sensible approach, I will try to add a test for this addition.

derrabus reacted with rocket emoji
@sanmaisanmai changed the titleCoverageListenerTrait update for PHPUnit 8.5/9.x[PhpUnitBridge] CoverageListenerTrait update for PHPUnit 8.5/9.xSep 4, 2020
@nicolas-grekasnicolas-grekas added this to the4.4 milestoneSep 4, 2020
@sanmai
Copy link
ContributorAuthor

sanmai commentedSep 4, 2020
edited
Loading

I think I addressed all comments. How should I test this change?

I seethere's a test, but it assumes a currently used version of PHPUnit. Should this be enough?

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I see there's a test, but it assumes a currently used version of PHPUnit. Should this be enough?

Yes, we're not going to test with multiple versions of phpunit.

@fabpot
Copy link
Member

Thank you@sanmai.

@fabpotfabpot merged commita19f91a intosymfony:4.4Sep 4, 2020
@derrabus
Copy link
Member

Thank you for working on this issue,@sanmai! 🚀

sanmai reacted with heart emoji

@sanmaisanmai deleted the pr/SymfonyTestsListenerTrait branchSeptember 4, 2020 11:53
fabpot added a commit that referenced this pull requestSep 5, 2020
…rait for PHPUnit 9.3 (sanmai, derrabus)This PR was merged into the 3.4 branch.Discussion----------[PhpUnitBridge] Adjust output parsing of CoverageListenerTrait for PHPUnit 9.3| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |#37637,#37564| License       | MIT| Doc PR        | N/AThis PR makes `CoverageListenerTrait` pass with PHPUnit 9.3. It contains a backport of#38054.The problem that is addressed here is that a one of the fixture classes is now included in the output despite having a coverage of zero. The test now accepts both cases:* The class is omitted from the output* The class appears with 0.00% coverage.Commits-------a3831dc [PhpUnitBridge] Adjust output parsing for PHPUnit 9.3.99c98bd [PhpUnitBridge] CoverageListenerTrait update for PHPUnit 8.5/9.x
nicolas-grekas added a commit that referenced this pull requestSep 8, 2020
…rait (sanmai)This PR was squashed before being merged into the 4.4 branch.Discussion----------[PhpUnitBridge] Skip internal classes in CoverageListenerTraitPHPUnit 9+ is picky about test covering, say, a `\RuntimeException`. Fails with the likes:    "@Covers RuntimeException" is invalidJudging by the commitsebastianbergmann/phpunit@e06850c this change is required for PHPUnit 9.1 and up. [Here's it being tested.](https://github.com/sebastianbergmann/code-unit/blob/60c6fb972b3262e423be3000e7b8c67cbc477580/tests/unit/ClassMethodUnitTest.php#L49-L54)| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | Follow-up to#38054| License       | MITCommits-------a0dedb9 [PhpUnitBridge] Skip internal classes in CoverageListenerTrait
This was referencedSep 27, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@derrabusderrabusderrabus left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@sanmai@fabpot@derrabus@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp